[bugfix] optimize array copying in engineUpdate() methods#101
Merged
Conversation
Correct Arrays.copyOfRange bounds in BotanMessageDigest and BotanMac to copy only requested bytes instead of copying to end of input array. Changes input.length to offset + len, eliminating unnecessary memory allocation and copying for operations with non-zero offsets. No functional change - cryptographic outputs remain correct. Performance improvement for offset-based update operations. Signed-off-by: Yasser Aziza <yasser.aziza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct Arrays.copyOfRange bounds in BotanMessageDigest and BotanMac to copy only requested bytes instead of copying to end of input array.
Changes input.length to offset + len, eliminating unnecessary memory allocation and copying for operations with non-zero offsets.
No functional change - cryptographic outputs remain correct. Performance improvement for offset-based update operations.