Skip to content

Conversation

mispencer
Copy link
Contributor

@mispencer mispencer commented Jun 27, 2025

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

Currently, there are two types of diagnostics highlighting: errors and everything else (effectively as warnings).

These changes adds two new highlighting for information and hint diagnostics, and provides sensible default for their highlighting and sign.


This change is Reviewable

Currently, there are two types of highlighting: errors and everything
else (effectively warnings).

This changes adds two new highlighting for information and hint
diagnostics, and provides sensible default for their highlighting
and sign.
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.83%. Comparing base (131b182) to head (1a791f8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
- Coverage   89.88%   89.83%   -0.05%     
==========================================
  Files          37       37              
  Lines        4763     4861      +98     
==========================================
+ Hits         4281     4367      +86     
- Misses        482      494      +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant