Add support for changing job_jobid_status.tsv filename#19
Open
mawilson1234 wants to merge 5 commits intoycrc:masterfrom
Open
Add support for changing job_jobid_status.tsv filename#19mawilson1234 wants to merge 5 commits intoycrc:masterfrom
mawilson1234 wants to merge 5 commits intoycrc:masterfrom
Conversation
It would be nice to be able to change the filename of the stats file to something more informative. (In particular, it would be nice to be able to include the job name instead of just the jobid.) This is an attempt to do that.
It would be nice to add support for changing the stats file name. This is an attempt to do that while maintaining backward compatibility.
Fix argparse message
documentation of stats-file name arg
update arg description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be helpful to be able to change the name of the
job_jobid_status.tsvfile. (In particular, I would find it useful to be able to allow it to use the job name.) Currently, it's only possible to change the directory the file is saved in using--status-dir, or to suppress the file entirely using--suppress-stats-file. I've added code todSQBatch.pythat should allow the user to specify the name of the stats file using a command line argument--stats-file. The default value is the same as the current hard-coded filename,job_jobid_status.tsv, so this should be backward compatible. In addition,%jcan be used to specify the job id when specifying this argument, as it does in SBATCH options. I've also updatedREADME.mdto reflect this change.