Conversation
ydah
force-pushed
the
pluginfy_with_lint_roller
branch
from
e2f4d8e to
6e91d52
Compare
This PR adds support for RuboCop's Plugin feature. It replaces the ad-hoc Inject with RuboCop plugins introduced in RuboCop 1.72. NOTE: Version 1.72.1 or later is specified, as it includes rubocop/rubocop#13837, which removes the Inject from spec_helper.rb. While 1.72.0 is sufficient for runtime, but specifying the patch version 1.72.1 keeps things simple.
ydah
force-pushed
the
pluginfy_with_lint_roller
branch
from
6e91d52 to
b099d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for RuboCop's Plugin feature.
It replaces the ad-hoc Inject with RuboCop plugins introduced in RuboCop 1.72.
NOTE: Version 1.72.1 or later is specified, as it includes rubocop/rubocop#13837, which removes the Inject from spec_helper.rb. While 1.72.0 is sufficient for runtime, but specifying the patch version 1.72.1 keeps things simple.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).[Fix #issue-number](if the related issue exists).{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).