Skip to content

[Filestore] issue-4547: add benchmark for index tablet DescribeData with 1 MiB requests #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SvartMetal wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Filestore] issue-4547: add benchmark for index tablet DescribeData with 1 MiB requests #4913

SvartMetal wants to merge 6 commits into from
+120 −3

Conversation

@SvartMetal
Copy link
Collaborator

@SvartMetal SvartMetal commented Dec 25, 2025 •
edited
Loading

#4547

svartmetal@svartmetal-ivm:~/nbs-github2/cloud/filestore/libs/storage/tablet/bench$ ./bench -b 100
No Keys in KeyConfig! Encrypted group DsProxies will not start
No Keys in KeyConfig! Encrypted group DsProxies will not start
tablet_helpers.cpp: SetPath # /tmp/tmpycCA8g/pdisk_1.dat
----------- TTablet_DescribeData_1MiBRequestSize ---------------
 samples:       3034
 iterations:    5686878
 iterations hr:    5.69M
 run time:      100.0040284
 per iteration: 39346.68827 (39.3K) cycles

perf

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 7d577f0.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9809 9808 0 0 0 1 0

@SvartMetal
Set DispatchedEventsLimit to one billion; enable in-memory-index cach…
6cf7f94 
…e with MixedBlocksOffloadedRangesCapacity set to one million
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 6cf7f94.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9810 9808 0 1 0 1 0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6cf7f94.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
49 49 0 0 0 0 0

@SvartMetal SvartMetal changed the title [Filestore] add benchmark for index tablet DescribeData with 1 MiB sized requests [Filestore] issue-4547: add benchmark for index tablet DescribeData with 1 MiB sized requests Dec 29, 2025
@SvartMetal SvartMetal changed the title [Filestore] issue-4547: add benchmark for index tablet DescribeData with 1 MiB sized requests [Filestore] issue-4547: add benchmark for index tablet DescribeData with 1 MiB requests Dec 29, 2025
@SvartMetal SvartMetal force-pushed the users/svartmetal/bench/2 branch from 2c4f6a5 to 9b5f098 Compare December 31, 2025 20:11
@SvartMetal SvartMetal force-pushed the users/svartmetal/bench/2 branch from 9b5f098 to 75e236c Compare December 31, 2025 20:16
qkrorlqr
qkrorlqr previously approved these changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@qkrorlqr qkrorlqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this only because nothing depends on this benchmark and just having a piece of code with a leak with no dependencies on this piece of code doesn't cause any real issues. But I don't like this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 75e236c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9809 9808 0 0 0 1 0

SvartMetal
SvartMetal commented Jan 1, 2026
View reviewed changes
contrib/ydb/library/actors/util/local_process_key.h
return Enum2Index[index];
const auto& enum2Index = Singleton<TEnum2Index>()->Enum2Index;
Y_ABORT_UNLESS(index < enum2Index.size());
return enum2Index[index];
Copy link
Collaborator Author

@SvartMetal SvartMetal Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload this change to YDB repository

@SvartMetal SvartMetal force-pushed the users/svartmetal/bench/2 branch from ddf63da to 7d3f0a7 Compare January 1, 2026 20:57
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c48db16.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9809 9806 0 2 0 1 0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c48db16.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4 4 0 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qkrorlqr qkrorlqr qkrorlqr approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SvartMetal @qkrorlqr