[NBS] issue-4875: support IO for fresh blocks writer#5331
Open
vladstepanyuk wants to merge 2 commits intomainfrom
Open
[NBS] issue-4875: support IO for fresh blocks writer#5331vladstepanyuk wants to merge 2 commits intomainfrom
vladstepanyuk wants to merge 2 commits intomainfrom
Conversation
vladstepanyuk
added
the
blockstore
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1372s): some tests FAILED for commit 18352b7.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 44s): all tests PASSED for commit 18352b7.
|
vladstepanyuk
force-pushed
the
users/vladstepanyuk/issue-4875/14
branch
from
18352b7 to
0d9d127
Compare
vladstepanyuk
force-pushed
the
users/vladstepanyuk/issue-4875/14
branch
from
c7df745 to
5672e5a
Compare
| { | ||
| using TBase = NActors::TActorBootstrapped<TFreshBlocksWriterActor>; | ||
|
|
||
| friend TIOCompanionClient; |
Collaborator
There was a problem hiding this comment.
friend struct же можно и убрать forward decalaration?
Collaborator
Author
There was a problem hiding this comment.
без forward declaration не компилится:
/home/iajwjw/github/nbs/cloud/blockstore/libs/storage/fresh_blocks_writer/fresh_blocks_writer_actor.h:62:21: error: unknown type name 'TIOCompanionClient'; did you mean 'IIOCompanionClient'?
std::unique_ptr<TIOCompanionClient> IOCompanionClient;
^~~~~~~~~~~~~~~~~~
IIOCompanionClient
/home/iajwjw/github/nbs/cloud/blockstore/libs/storage/partition_common/io_companion.h:23:7: note: 'IIOCompanionClient' declared here
class IIOCompanionClient: public IMortalActor
komarevtsev-d
previously approved these changes
Feb 27, 2026
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1264s): some tests FAILED for commit 5672e5a.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 44s): all tests PASSED for commit 5672e5a.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4875