Add traceparent to TRequestSettings #326 #400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gazizonoki
requested changes
Apr 15, 2025
Gazizonoki
reviewed
Apr 21, 2025
|
|
||
| // Add TraceParent to headers (if it is set) | ||
| if (!settings.TraceParent_.empty()) { | ||
| rpcSettings.Header.emplace_back("traceparent", settings.TraceParent_); |
There was a problem hiding this comment.
На будущее, лучше traceparent сразу до инициализации Aux прокидывать (в grpc_connections.h).
Смысл такой - нам хочется в grpc_connections.h тоже собирать спаны, удобно, если там будет TraceParent отдельным параметром.
Пока можно так замержить, но в будущем стоит поправить.
zarinatlupova
force-pushed
the
traceparent
branch
from
487877c to
20ea715
Compare
|
PR merged in ydb repo: ydb-platform/ydb#17561 and synced to ydb-cpp-sdk repo: aec1485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена поддержка передачи traceparent (стандарт W3C TraceContext) через gRPC-заголовки. Это позволяет:
Как это работает
TraceParentвTRequestSettings.TRequestSettingsпреобразуется вTRpcRequestSettingsAux.TGRpcRequestProcessorCommonавтоматически добавляет его вgRPC-заголовки какtraceparent. Поддерживаются все типы запросов (синхронные, асинхронные, streaming).TraceParentпуст — заголовок не передается.В дальнейшем при интеграция с OpenTelemetry:
TraceParentможно будет автоматически брать извне (например, из OpenTelemetry Context).Формат
Заголовок соответствует W3C TraceContext:
trace_id: 32 hex chars (16 bytes)parent_span_id: 16 hex chars (8 bytes)flags:01(sampled)