Import YDB C++ SDK 19 #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR imports changes from the YDB C++ SDK repository, specifically moving bridge pile configuration from the request level to the location level in the discovery API. The changes refactor how bridge pile information is structured and handled in node discovery operations.
Key changes:
- Moved
BridgePileNamefromTNodeRegistrationSettingstoTNodeLocationstructure - Removed deprecated
BridgePileIdandpile_idfields from various protobuf messages - Added new Kafka error code for duplicate sequence numbers
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/client/discovery/discovery.cpp | Updates constructor to initialize BridgePileName in TNodeLocation and moves bridge pile name handling from request to location |
| src/api/protos/ydb_discovery.proto | Adds bridge_pile_name field to NodeLocation and removes bridge_pile_id/bridge_pile_name from other messages |
| src/api/protos/draft/ydb_maintenance.proto | Removes deprecated pile_id field from Node message |
| src/api/protos/draft/persqueue_error_codes.proto | Adds KAFKA_DUPLICATE_SEQUENCE_NUMBER error code |
| include/ydb-cpp-sdk/client/discovery/discovery.h | Moves BridgePileName from TNodeRegistrationSettings to TNodeLocation and removes BridgePileId from TNodeInfo |
| .github/last_commit.txt | Updates commit hash tracking |
| .github/import_generation.txt | Increments import generation number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic import of new commits from ydb repository