Skip to content

dev: fix flap in tests (run processing ack may not be able to start on time) #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2024
Merged

dev: fix flap in tests (run processing ack may not be able to start on time) #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f866b71
Revert "Release v0.9.v0.9.1"
KirillKurdyukov Dec 17, 2024
a69d303
Merge remote-tracking branch 'origin/main'
KirillKurdyukov Dec 17, 2024
d35a976
Merge remote-tracking branch 'origin/main'
KirillKurdyukov Dec 18, 2024
2a05f24
Merge remote-tracking branch 'origin/main'
KirillKurdyukov Dec 19, 2024
93530f0
dev: fix flap tests (run processing ack may not be able to start on t…
KirillKurdyukov Dec 19, 2024
17c7d2d
Ado.Net NextResultAsync on skipping any more messages in ExecuteScala…
KirillKurdyukov Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Ydb.Sdk/src/Ado/YdbCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public override async Task<int> ExecuteNonQueryAsync(CancellationToken cancellat
{
await using var dataReader = await ExecuteReaderAsync(cancellationToken);

while (await dataReader.ReadAsync(cancellationToken))
while (await dataReader.NextResultAsync(cancellationToken))
{
}

Expand All @@ -51,7 +51,7 @@ public override async Task<int> ExecuteNonQueryAsync(CancellationToken cancellat
? dataReader.IsDBNull(0) ? null : dataReader.GetValue(0)
: null;

while (await dataReader.ReadAsync(cancellationToken))
while (await dataReader.NextResultAsync(cancellationToken))
{
}

Expand Down
6 changes: 4 additions & 2 deletions src/Ydb.Sdk/tests/Topic/WriterUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ public async Task Initialize_WhenFailWriteMessage_ShouldRetryInitializeAndReturn
Assert.Equal(PersistenceStatus.Written, (await writer.WriteAsync("abacaba")).Status);

// check attempt repeated!!!
_mockStream.Verify(stream => stream.Write(It.IsAny<FromClient>()), Times.Exactly(3));
_mockStream.Verify(stream => stream.Write(It.IsAny<FromClient>()),
Times.AtLeast(2)); // run processing ack may not be able to start on time
_mockStream.Verify(stream => stream.MoveNextAsync(), Times.Exactly(3));
_mockStream.Verify(stream => stream.Current, Times.Exactly(2));
}
Expand Down Expand Up @@ -178,7 +179,8 @@ public async Task Initialize_WhenFailMoveNextAsync_ShouldRetryInitializeAndRetur

// check attempt repeated!!!
_mockStream.Verify(stream => stream.Write(It.IsAny<FromClient>()), Times.Exactly(3));
_mockStream.Verify(stream => stream.MoveNextAsync(), Times.Exactly(4));
_mockStream.Verify(stream => stream.MoveNextAsync(),
Times.AtLeast(3)); // run processing ack may not be able to start on time
_mockStream.Verify(stream => stream.Current, Times.Exactly(2));
}

Expand Down
Loading