fix: memory leak CancellationTokenRegistration #242

KirillKurdyukov · 2024-12-24T15:35:52Z

Do not pessimize the node on Grpc.Core.StatusCode.Cancelled.
Dispose of WriterSession using dispose CancellationToken.
BidirectionalStream is internal class.
Move Metadata class to Ydb.Sdk.Services.Topic.
Fixed memory leak CancellationTokenRegistration.
Cancel writing tasks after disposing of Writer.

2) Dispose of WriterSession using dispose CancellationToken. 3) BidirectionalStream is internal class. 4) Move Metadata class to Ydb.Sdk.Services.Topic. 5) Fixed memory leak CancellationTokenRegistration. 6) Cancel writing tasks after disposing of Writer.

github-actions · 2024-12-24T15:56:30Z

🌋 Here are results of SLO test for AdoNet:

Operation Success Rate

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [99.924,99.933,99.95,99.946,99.951,99.954,99.972,99.96,99.969,99.965,99.967,99.968,99.975,99.971,99.973,99.978,99.975,99.976,99.977,99.978,99.979,99.979,99.962,99.777,99.976,100.01,99.993,99.99,99.945,100.003,100,100.003,100,100,100,99.993,100,99.997,100,100,100,99.997,100,100.048,99.997,100.003,100,100,100,100,100,99.997,99.997,100,99.949,100,100.003,100,99.997,100,99.993,100,100,100,100,100,100,100,100,100,100,100,99.951,100.003,99.997,100,100,100,100,100,100,100,99.962,99.962,99.962,99.958,99.962,99.962,99.965,99.965,99.962,99.962,99.962,99.962,99.962,99.962,99.962,99.969,99.965,99.966,99.966,99.962,99.959,99.962,99.962,99.962,99.962,99.962,99.962,99.962,99.962,100,100,100.003,100.003,100,100,99.997,99.997,100,100.021,100,100,100.003,100,100.028,99.997,99.997,99.997,99.997,100,100,100,100.003,100,100,100,100,100,100,100.007,100.003,99.972,99.941,99.945,99.945,99.952,99.944,99.945,99.924,99.945,99.952,99.942,99.945,99.917,99.945,99.945,99.944,99.944,99.944,99.944,99.948,99.945,99.945,99.945,99.945,99.945,99.952,99.945,99.938,99.941,99.99,100.007,100,100,99.993,100,100,100,100,100.035,100,100,100.007,99.997,100,100,100,100,100,99.997,99.997,100,100.017,100,100,99.993,100.003,100,100.003,99.979,99.997,100,100,100.007,100,100,100,100,99.959,100,100,99.993,100,100,100,100,100,100,100,100.003,100,99.983,100,100,100,99.997,100,100,100,100,100.007,100,99.993,100,100,100,100,100,100.003,100,100,100,100,100,100,100,100,100,99.997,100,100,100.003,100,100,100,100,99.997,100,99.997,99.993,100,100,100,100,100,100,100,99.997,100,100,100,100.003,100,100,100,100,100,100,100,100.003,99.997,100,100,100,100,100,100,100,100,100.017,100,100,100,100,100,100,100,100,100.003,100,99.997,100,100,100,100,100,100.003,100,99.997,100,100,100,100,100.007,100,100,100,100.017,99.983,100,100,100.003,100,100,100,100,100,99.997,100,100,100.024,100,100,100,100,99.997,100,100.007,100.007,100.003,100,100,99.993,100,100,100,99.983,100,100,100,99.997,100,100,100,100,100,100,100,100,99.976,100,100.014,100.007,100,100.003,100.007,99.993,99.993,99.997,100,100.007,100,100,100,100,100.003,100,100.003,100,100.003,100,100,100,100,100,100,100,100,100,100,99.986,99.993,100,99.997,99.993,100,100,100,100,99.993,100,100,100,100,99.997,100,100.003,100,99.997,100,100,100,100,100,100,100,100,100,100,100,100.01,100,100.003,100,100,100,100,100,100.003,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.99,100,99.997,100,100,100,100,100.003,100,100.003,100,100,100,100,100,99.997,100,100,100,100,100,100,100,100,100,100.003,100,100,100,100,100,100,100,100,100,100,100,99.997,99.997,100,100,100,100,100,99.997,100,100.048,100,100,100,100,100,100.003,100,99.997,100,100,100,100,100,100,100,100,100,100,99.997,100.003,100,100,100,100,100,100,100,100,99.952,100.007,100,100,100,100.003,100,100,100,100,100,100,100,100.007,100.003,100.003,100,100,100,100,99.997,100,100,100,100,100,100,100,100,100,99.993,100,100,100,100.003,100,100,100,100,100,100,100,100,99.997,99.997,100,100.003,100,100,100.003,100.003,100,100,100,100,100,100,100,100,100,100.003,100,100.003,99.993,99.997,100,100,100]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "	Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [99.975,99.967,99.97,99.973,99.975,99.977,99.979,99.98,99.982,99.988,99.983,99.984,99.985,99.995,99.986,99.991,99.988,99.988,99.989,99.989,99.989,99.99,99.925,99.997,99.983,100.045,99.99,99.962,99.997,99.997,100,100.003,100.007,100.007,100,100,100,100,99.997,100,100,100,99.993,100.007,99.997,100,100,100,100,100.003,100,100,100.017,100,99.952,100,100,100,100,100.003,99.997,99.993,99.993,100,100,100,100,100,100,100,100,100,99.997,100,100.003,100,100,100,99.997,100,100,99.983,99.965,99.965,99.965,99.965,99.965,99.965,99.962,99.965,99.969,99.965,99.965,99.965,99.965,99.965,99.966,99.969,99.965,99.969,99.969,99.962,99.966,99.962,99.966,99.966,99.966,99.965,99.965,99.965,99.965,100,100,100,100.007,100.01,100.003,100.003,100,99.997,100,100,100,100,100,100.007,99.997,100.003,99.997,99.997,100,100,100,100.024,100,100,100,100,100,100,100,100,100,99.952,99.948,99.955,99.955,99.958,99.962,99.962,99.962,99.959,99.959,99.959,99.952,99.962,99.955,99.958,99.958,99.958,99.958,99.959,99.938,99.962,99.959,99.959,99.959,99.962,99.959,99.959,99.959,99.959,100,100,100,100,100,99.997,100,99.997,100.076,100,100,100.003,99.997,100,100,100,100,100,100,99.997,99.997,100,100.003,100,99.997,100,100,100,100.007,100,100.014,100,100,100,100,99.997,100,99.925,100,100.003,99.997,100,100,100,100.003,100,100,100,100,100,100,99.997,100.007,100,100,100,100.007,99.993,100,99.986,100,100,100,100,100.003,100,100,100,99.997,100,100,100,100,99.997,100.007,100,100,100,100,100,100.007,99.993,100,100.003,100,99.993,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.993,100,100,100.003,100,100,99.997,100.007,100,99.997,100,100,100,100.01,100.007,100,100,100,100,99.997,100,100,100,100,100,100,100,100,100,100,100,100.003,99.997,100,100,99.997,99.993,100,100,100,100,100,99.99,100.021,100,100,100,100.003,100,100,100,100,100,100,100,100,100,100,100,100,99.997,100,100,100.031,100,100.003,100,100,100,100,100,100,99.972,100.003,100,100,99.997,100,100,100,100,100,100,100,100,100,100,100.045,100,100.003,100.003,100.007,99.969,100,99.997,100,100,100,100,100,100,100,99.997,100,100.003,100,100.01,100,100,100,100,100,100,100,100,100,99.955,100,99.997,99.997,99.993,100,100,100,100,100,100,100,100,100,100,100,100,99.997,100,99.993,100,100,100,100,100.01,100.01,100,100,100,100.003,100,100,100,100,100,100,100,100.007,100.01,100,100,100.003,100,100,100,100,100,100,99.997,100,100,100,100,99.99,99.99,100,100,100,99.997,100,100,100,100,100,100,100,99.993,99.99,100,100,99.997,100,100,100,100,100,100,100,100,100,100,100.007,100,100,100.01,100,100,100,100,100,100.003,100,100,100,100,100.003,100,100,100,100,100,100,100,100,100.003,100.024,100,100,100,100,99.993,100,100,99.99,100,100,100,100,100,99.997,100,100.003,100,100,99.997,100,100,100,100.003,100,100,100,100.01,99.997,99.976,100,100,100,100,100,100,100,100,100.003,100,100,100,100.007,100,100.003,99.997,100,100,100,100,100,100,99.997,100,100,100,99.99,100,100,100,100,100,100,100,100,100,100,99.997,100,100,100,99.993,100,99.997,100,100,100.003,100,100,100,100,100,100,100,100,100,100,100.003,100,100.003,100,100,100,100,100,100.003,100.004]

Operations Per Second

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 259 --> 1114
    line [288.007,324.989,360.94,395.219,432.077,455.54,500.231,524.993,566.041,598.623,624.994,658.501,693.426,726.549,760.708,793.246,828.434,861.763,895.093,928.423,961.753,998.862,1004.448,1006.862,1005.552,996.139,996.172,995.897,994.966,1002.828,999.69,999.034,1000,997.034,1007.828,995.897,1005.103,998.966,999.69,1006.586,1006.414,1004.828,1005.034,1005.483,998.103,1005.276,996.241,996.241,996.379,996.414,1001.414,996.379,996.586,996.552,1005.174,1004.276,1004.793,1005.138,1003.724,1006.827,1005.034,1003.138,1002.655,1001.483,1002.276,1001.759,1000.345,993.103,1000.586,1000.586,991.966,993.103,992.034,1000.517,990.793,1000.931,1003.448,1003.31,1002.931,1002.724,1003.034,1003.621,986.862,999.862,992.69,995.206,997,998.69,995.31,994.517,994.759,996.552,996.552,996.552,996.276,996.207,1003.448,996.724,997.034,1004.966,1003.414,1004.172,1006.379,1007.069,1005.966,1003.448,1003.448,996.897,996.552,996.552,995.759,1009.69,996.827,1004.966,1001.207,999.586,997.414,999.138,1002.034,1001.793,998.207,1000,1000,1000.828,1000.828,1000.862,1000.655,999.586,1003.069,1003.483,1002.517,1000,1000,989.69,1000,993.103,1006.931,1000,1006.966,1000.241,1000.69,1000,993.621,997.448,1000.966,1003.931,1003.414,993.103,1000.897,1002.483,1001.276,1000.414,1002.621,1002.621,1002.586,998.655,1002.689,993.103,993.103,993.103,993.103,1001.103,1005.621,994.655,1003.448,999.966,1006.897,998.862,1006.655,1006.207,999.862,1012.31,1008.827,997.31,996.483,994.897,1003.862,995.759,996.552,994.828,997.414,996.552,996.552,995.517,999.931,996.655,1003.621,1003.448,1003.448,1003.448,995.448,1004.69,1005.345,1002.966,999.966,1000,1000.621,1000,993.001,1005.138,996.897,997.896,1005.138,1005.311,1004.517,1006.483,1006.793,1006.207,1004.103,1005.621,996.552,998.483,999.828,1000.103,1000.069,1000.414,999.414,1000.103,1003.448,1003.448,997.172,1000,1000.483,1000.034,993.103,1000.448,993.034,1000.103,993,995.241,994.656,994.897,994.483,996.586,996.552,996.552,995.379,999.793,996.449,1003.793,1004.896,1004.655,1003.345,1003.38,1002.862,994.724,1004.793,993.103,993.103,1002.552,993.103,993.966,994,1000.103,994.103,1000.172,1000.138,1001.862,1000.034,1000.172,1003.414,1003.724,1002.759,1000,1000,1000.138,1000.207,1003.552,1003.103,989.827,999.966,999.931,1001.31,993.103,1002.414,991.655,1000,1000,994.034,1000.862,999.828,998.103,1000.207,1002.448,1003.345,1003.31,1003.448,1003.414,1004.207,1000.379,1000.862,1001.345,1000.966,1003.448,1004.483,1003.241,1000,1000,1002.207,1000.103,993.069,991.793,1000,1000,1000.069,1001.207,1001,1000.379,999.759,1002.759,1004.344,1003.138,1000,1000,999.172,1000.172,1000.069,999.034,997.724,999.172,1002.103,1002.483,998.379,1000,1000,1000.172,993.103,1001.138,993.034,1007.035,997.724,1000.172,1003.344,1003.379,1002.241,1002.448,1002.414,1003.448,1000.793,1001.138,1001.517,1001,1003.448,1004.276,1003.276,1003.379,1003.448,995,1004.069,993.103,993.035,994.724,993.103,993.172,993.103,1000.103,1000.138,1000.069,996.517,1005.724,1003.276,1000.103,999.793,999.241,1001.379,1001.793,1001.448,999.207,992.069,1001.931,1002.448,997.828,1000,1000,993.103,993.103,1011.793,999.379,999.828,999.345,1000.034,1000.896,1000.31,998.241,1000.862,1003.31,1003.379,1000,1000,1000,1000.448,1000.345,1000.793,998.897,998.483,1001.379,1003.448,1010.345,1000,1000,1000.621,1000.103,993.103,1007.345,1000,998.897,993.103,1000.931,1000.759,1000,999.345,1003.069,1005,1001,1000,1000,998.655,1000,1000.069,999.828,999.759,1000.966,1003.172,1004.138,993.103,993.103,993.103,993.103,993.103,995.207,993.345,1000.517,991.414,1000.621,996.207,1003.414,1002.621,1003.414,1003.414,1003.483,1000.552,1000.034,1001.793,1000.034,1003.448,1004.793,1003.448,1003.379,1003.172,1003.552,1003.138,993.103,999.172,1000,1000,1000.207,1000.517,1000.069,1000.103,1000.241,1002.931,1004.69,1002.828,1000,1000,999.448,1000.241,1000.586,999.793,998.828,1000.414,993.103,996.276,992.172,991.172,992.241,993.103,993.103,993.103,992.414,999.862,991.379,1000.034,1000,999.862,999.448,1000.517,1002.793,1002.862,1000,1000,1000,1000.103,1000.034,1000.897,1000.034,999.552,1003.379,1004.069,1003.035,1010.034,1007.138,997.586,1001.931,1000.862,998.172,999.862,1000,1000.034,1000.138,1001.586,1000.172,1000.31,1003.379,1003.483,1003.793,1000.172,1000.414,999.103,1000.172,1003.448,1003.345,1003.414,995.241,1003.172,996.414,992.862,993.103,993.103,993.103,992.724,1003.621,1000.172,1000.172,1000.31,1000.483,1003.448,1003.793,1004.138,1003.966,1005.586,1004.517,1003.448,1003.448,1002.517,1003.276,1003.034,994,996.379,993.103,990.586,993.103,1001.034,993.414,1000.414,1000.862,1000.345,1000.103,1003.448,1002.897,1002.345,1001.862,1003.276,1004.31,1003.172,1003.448,1003.069,1001.379,1002.931,1001.103,995.172,992.897,993.655,993.897,994.621,993.207,1005.552,1003.448,1003.448,1005.966,1003.448,1003.448,1003.586,992.862,996.448,998.379,1006.793,993,996.966,997.379,997.966,1000,966.172]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 259 --> 1112
    line [287.934,325.097,358.897,395.326,432.183,454.94,499.036,525.098,566.634,598.136,625.099,659.922,692.319,727.62,760.88,794.175,828.537,861.866,895.196,928.525,961.856,999.517,1005.172,1003.862,1006.414,995.725,995.931,995.759,992.724,1001.966,999.552,1001.069,999.931,997.241,1006.586,997.621,1005,998.345,1000.138,1006.448,1004.966,1005.897,1003.759,1004.034,997.138,1003.483,996.103,996.103,996.172,996.586,1000.207,996.689,996.414,996.552,1005.346,1003.448,1003.517,1004.276,1005.138,1006,1004.931,1003.069,1002.31,1003.276,1001.69,1001.448,1000.069,993.103,1000.103,1000.103,991.828,993.276,993.552,1000.172,992.034,1001.241,1003.448,1003.379,1000.759,1003.241,1003.241,1002.793,987.759,999.276,993.103,996.482,997.379,996.552,994.827,993.552,993.448,996.552,996.552,996.552,996.552,996.483,1003.414,996.69,996.759,1006,1002.586,1002.966,1006.724,1007.483,1005.655,1003.448,1003.448,998.759,996.552,996.552,996.483,1008.793,997.896,1003.69,1001.586,999.655,999,1001.103,1003,1003.103,999.862,1000,1000,1000.897,1000.379,1000.207,1000.276,1000.207,1002.172,1004.31,1003.448,1000,1000,989.793,1000,993.103,1006.897,1000,1006.897,1000.069,1000.448,1000.172,996.379,998.414,999.897,1003.966,1002.448,993.103,1001.207,1001,1001.414,1000.379,1002.552,1003.069,1003.276,999.862,1002.827,993.103,993.103,993.103,993.103,1000.552,1004.138,994.448,1003.448,1000,1006.897,999.621,1006.828,1006.448,999.931,1010.828,1006.827,998.793,996.483,995.586,1003.517,995.414,995.897,994.345,996.448,996.552,996.552,995.517,999.621,996.655,1003.448,1003.448,1003.448,1003.621,996,1006.069,1005.552,1003.448,999.966,1000,1000.241,1000,993.001,1004.793,996.793,997.448,1004.552,1005.621,1004.241,1006.828,1006.828,1006.69,1004.517,1006.621,996.552,999.448,999.724,1000.138,999.897,1000.069,998.655,1000.069,1003.276,1003.448,998.897,1000,1000,1000.034,993.034,1000.138,992.931,1000.103,993.966,995.759,995.759,995.483,993.276,995.931,996.552,996.552,994.828,999.724,996.449,1003.448,1003.931,1004.759,1003.31,1003.552,1003.379,994.897,1003.828,993.103,993.103,1000.138,993.103,993.103,994.069,1000.69,993.448,1000.241,1000,1001.241,1000.034,999.966,1003.414,1004.621,1003.31,1000,1000,1000.069,1000,1003.552,1003.448,989.723,998.897,999.931,1000,993.103,1003,992.655,1000,1000,994.828,1000.207,1000.034,997.793,1000,1003.103,1003.379,1003.448,1003.448,1003.414,1003.897,1000.655,1000.345,1001.345,1000.103,1003.448,1005.103,1003.448,1000,1000,1000.138,1001.207,993.069,993.103,1000,1000,1000.379,1000.483,1000.207,999.414,999.897,1003.414,1004.586,1002.828,1000,1000,998.931,1000.172,1000,999.552,997.345,999.655,1002.103,1003.345,999.655,1000,1000,1000,993.103,1003.31,993,1007.001,998.31,1000,1003.344,1003.069,1002.966,1003.241,1003.276,1003.655,1001.793,1000.207,1000.31,1000.241,1003.448,1004.517,1003.276,1003.448,1003.448,995.172,1004,993.103,993.035,993.448,993.103,993.103,993.103,1000,1000,1000.069,996.552,1004.172,1003.448,1000.103,998.793,998.966,1000.897,1000.655,1000.724,999.207,993,1003.138,1003.207,999.931,1000,1000,993.103,993.103,1010.276,999.448,999.138,998.345,1000.448,1000.483,1000.483,999.69,1000,1003.448,1003.379,1000,1000.966,1000,1000.207,1001.207,1001.034,999.31,999.379,1002.414,1002.448,1010.345,1000,1000,998.655,1000,993.103,1006.897,1000,1000.172,993.103,1001.69,1001.724,999.552,1000.138,1002.966,1003.759,1002.724,1000,999.241,998.172,1000,1000,999.793,999.345,1000.069,1003.241,1003.724,993.103,993.103,993.103,993.103,992.069,994.862,993.103,1000,992.207,1000.276,996.379,1003.448,1002.621,1003.448,1003.448,1003.931,1000.414,1000,1000.724,1000,1004.207,1005.276,1003.448,1003.448,1003.448,1002.586,1003.379,993.103,1000.138,1000,1000,1000.069,1000.103,1001.034,1000.276,1000.69,1003.448,1004.345,1003.172,1000,1000,998.276,1000,1000.241,998.897,998.276,999.931,993.103,996.379,992.69,992.966,991.586,993.103,993.103,994.621,993.103,999.862,991.862,1000,1000,999.931,998.276,1000.172,1002.828,1002.759,1000,1000,1000,1000,1000,1001.724,1000,999.759,1003.448,1004.759,1003.517,1010.345,1007.069,996.966,1000.138,1001.517,998.897,999.862,1000,1000,1000.138,1000.793,1000.103,1000.241,1003.448,1005.069,1004.31,1001.034,1000.724,999.138,1000.379,1003.448,1003.448,1003.448,995.138,1003.448,996.552,993.103,993.103,993.103,993.103,991.759,1003.448,1000,1000.172,1000.207,1000.138,1003.448,1003.793,1003.793,1003.552,1003.897,1003.655,1003.448,1003.448,1002.414,1002.414,1002.724,993.966,996.172,993.103,991.552,993.103,1001.414,993.103,1000,1000,1000,1000.207,1003.448,1004.586,1003.345,1003,1003.276,1002.621,1003.448,1003.448,1003.103,1002.379,1003.345,1002.897,996.103,993,994.966,993.69,993.759,993.31,1004.103,1003.448,1003.448,1005,1003.448,1003.448,1003.483,995.966,996.724,997.31,1006.69,993.724,994.138,996.655,997,999.966,967.207]

95th Percentile Latency

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 66 --> 335
    line [304.231,276.959,250.331,224.893,199.765,198,194.758,192.909,190.191,188.11,186.244,183.936,181.499,179.188,177.546,176.099,174.346,172.207,170.068,167.944,166.437,170.193,171.65,149.913,109.049,99.608,99.32,97.98,94.501,94.57,94.721,94.866,94.04,92.653,92.373,92.963,93.932,93.46,92.573,92.266,92.219,93.533,94.492,93.229,92.492,91.718,91.933,92.391,92.991,92.328,88.694,84.233,85.889,86.278,86.052,85.456,84.958,85.286,85.581,85.633,85.496,85.098,85.336,85.42,86.244,84.926,84.443,84.738,84.9,86.116,84.668,84.542,85.849,86.211,86.886,87.147,86.993,86.085,86.165,85.998,86.207,84.223,88.285,200.973,203.205,202.475,201.883,201.333,202.412,202.645,202.571,202.02,202.02,202.02,202.105,202.126,199.956,201.925,201.862,199.733,199.96,199.637,199.323,199.181,199.372,199.734,199.749,201.494,201.6,201.6,201.843,172.905,90.464,87.281,86.578,87.133,87.343,87.72,86.423,84.38,84.942,84.76,86.465,86.046,85.387,84.81,85.164,85.685,85.34,84.908,84.89,84.929,85.983,84.686,85.844,85.054,85.505,85.777,85.947,86.061,84.958,83.825,85.546,126.885,136.978,133.086,133.894,132.789,135.042,147.471,148.166,142.32,141.622,144.341,146.13,146.184,143.974,144.902,146.393,146.393,147.549,143.876,145.07,143.507,145.165,145.722,144.721,147.845,145.247,147.691,149.132,145.243,89.555,87.732,88.2,87.846,87.606,87.15,84.297,82.986,83.371,82.043,81.28,81.464,81.54,82.628,81.543,80.521,80.521,81.904,83.298,82.031,82.263,81.6,82.832,83.984,82.525,82.559,81.865,82.991,82.392,83.616,84.552,83.829,83.495,85.004,85.8,84.574,83.567,83.219,84.201,85.393,84.83,85.452,84.445,85.375,85.504,86.482,86.038,85.129,84.916,85.106,85.829,85.351,84.005,83.947,84.369,85.007,83.985,85.353,84.508,83.817,84.255,87.395,87.117,85.554,85.349,85.686,86.143,86.347,84.537,84.399,84.297,85.652,85.438,85.072,83.656,83.2,84.441,84.711,85.362,83.693,83.638,83.899,85.438,86.061,84.765,84.544,83.926,85.179,85.855,84.199,80.307,80.339,81.97,82.527,83.15,82.036,81.239,81.432,82.695,83.193,81.299,80.368,84.816,86.072,86.583,85.277,84.521,84.229,85.75,85.801,86.409,84.956,84.465,85.474,85.544,86.013,84.516,83.554,83.773,84.589,85.103,84.045,83.349,82.854,84.493,85.696,85.837,85.154,85.262,85.726,85.336,82.523,81.721,80.854,80.483,81.738,82.373,80.441,79.521,79.277,80.308,81.227,79.943,80.446,79.132,79.975,79.478,81.025,80.198,79.035,79.691,80.576,82.002,82.058,79.76,80.541,81.334,81.576,80.977,82.911,81.415,82.106,83.329,83.353,83.673,82.587,83.161,83.264,83.525,84.181,83.475,83.428,83.692,84.648,85.196,85.152,84.108,84.352,84.503,83.742,84.984,84.7,83.788,84.076,84.673,85.3,85.561,85.331,84.31,85.008,85.518,84.333,85.103,84.42,84.84,85.157,85.736,86.208,85.338,85.165,85.466,85.646,85.57,84.234,84.742,85.571,87.702,87.742,88.287,87.047,86.883,86.945,87.687,87.61,87.006,86.272,86.457,87.266,87.498,86.349,85.882,85.692,86.054,86.505,85.554,84.944,84.564,85.255,84.735,85.575,84.885,84.572,84.735,84.983,84.484,80.821,79.693,79.664,79.781,79.342,78.166,76.262,76.773,76.525,75.528,76.674,74.216,73.71,75.639,76.464,77.427,76.301,75.129,76.574,78.777,78.939,76.807,76.657,75.895,77.932,77.078,78.676,78.175,78.479,80.08,80.059,80.462,79.617,78.743,78.621,80.35,81.186,81.571,81.852,81.469,82.724,83.681,82.547,82.234,81.852,81.605,81.233,81.9,80.358,79.275,79.288,81.557,82.607,81.779,81.65,80.986,81.328,82.602,81.345,81.793,81.035,82.118,81.762,82.839,82.104,82.981,81.883,82.683,83.522,83.733,81.742,82.766,83.684,84.321,84.494,85.393,84.617,86.013,86.275,86.752,86.239,85.148,84.975,84.762,85.839,86.358,85.017,84.905,85.375,86.496,86.527,86.206,85.841,85.669,84.352,84.476,84.758,84.468,83.702,84.246,84.36,84.539,83.175,82.941,83.004,84.407,83.808,83.423,82.832,82.527,83.593,83.011,83.954,82.871,82.4,82.35,82.613,83.721,83.35,82.525,83.655,83.76,84.511,83.628,84.037,82.896,83.136,83.798,84.737,84.912,84.291,85.341,85.482,85.52,84.984,84.932,84.803,85.699,86.083,86.12,86.173,86.357,86.123,86.137,86.238,87.174,87.108,86.4,86.651,86.404,87.455,87.29,87.534,87.607,88.767,88.85,89.254,89.461,89.907,90.226,90.285,90.791,91.562,91.699,91.558,91.643,91.559,91.196,91.026,91.02,90.794,90.807,91.037,90.804,90.69,90.678,93.633,133.47,136.813,138.837,142.303,140.76,139.47,141.163,141.633,143.432]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 73 --> 218
    line [197.338,194.612,192.13,189.758,187.409,185.768,182.997,181.198,178.864,177.413,175.814,173.996,171.926,169.674,168.056,166.81,165.022,162.998,160.974,159.016,158.309,159.764,161.314,143.021,105.962,99.066,99.465,95.866,94.173,93.326,93.256,94.339,94.33,93.693,93.496,93.516,93.978,93.859,92.747,92.651,92.348,93.649,94.513,94.079,93.453,93.469,93.615,94.823,95.391,94.508,92.602,89.623,90.385,90.919,91.021,90.604,90.748,91.897,92.927,92.96,92.586,92.186,92.814,92.8,93.451,93.512,92.953,93.141,93.042,93.787,92.785,92.527,93.835,93.93,94.017,94.2,93.234,92.612,92.609,92.441,93.282,92.907,96.433,195.132,196.596,196.341,195.975,195.827,196.057,196.237,196.43,195.988,195.988,195.734,195.67,195.955,195.087,195.89,195.614,194.625,195.179,194.514,193.916,193.721,194.062,194.167,194.486,195.34,195.623,195.335,195.396,169.388,93.89,91.82,91.91,92.205,92.827,93.355,92.642,91.611,91.65,91.583,93.031,93.156,92.47,92.446,92.72,93.757,93.978,93.317,93.147,93.436,94.337,93.844,94.214,93.61,93.032,93.045,93.782,93.943,93.186,92.451,93.672,143.323,143.99,140.398,143.286,141.912,144.573,148.883,149.803,146.165,145.687,149.045,149.792,149.821,146.258,145.332,146.809,146.765,146.852,142.238,142.644,141.734,143.211,144.816,143.98,142.507,136.742,139.752,143.014,138.009,89.422,89.425,89.974,88.826,88.687,87.565,86.356,84.952,84.69,83.78,82.51,83.002,82.817,83.403,82.623,82.004,82.004,83.097,83.829,83.056,82.937,82.272,82.242,83.348,83.282,83.414,82.795,83.109,82.685,84.286,84.016,83.346,83.488,84.85,86.546,86.765,86.129,86.251,86.245,87.226,86.8,87.339,86.694,86.547,86.964,87.946,87.949,87.429,87.787,87.862,88.861,89.497,88.561,87.803,88.515,89.331,88.525,88.924,88.051,87.788,88.191,90.588,90.895,89.102,87.888,87.913,88.877,89.536,87.955,87.708,87.403,88.891,89.503,88.872,87.711,87.615,88.908,89.205,90.027,88.8,88.211,88.36,90.002,90.527,88.775,88.675,88.54,90.026,90.817,89.064,86.258,85.247,87.382,87.475,88.291,86.81,86.379,86.991,88.925,90.111,88.469,87.916,91.345,91.985,92.589,91.705,90.952,90.504,91.462,91.271,91.829,90.525,89.702,90.863,90.852,91.961,90.81,90.034,90.11,90.64,91.399,91.256,90.896,90.306,91.274,92.006,91.865,90.873,90.095,90.542,90.153,88.011,87.598,86.602,86.091,87.115,88.102,87.319,86.86,86.714,87.456,88.877,87.573,88.188,86.99,87.475,87.46,88.526,88.849,88.179,87.632,87.758,89.188,89.406,88.209,88.426,88.63,89.68,89.796,90.651,89.187,89.16,89.62,89.684,90.278,89.728,89.452,89.528,89.435,90.314,88.92,89.214,88.9,89.033,89.958,89.658,89.206,88.286,88.147,87.207,88.686,87.941,87.252,86.988,87.651,88.093,87.098,86.637,86.303,86.86,87.693,87.732,88.204,86.82,86.443,86.845,87.234,87.313,86.102,86.231,86.324,87.05,88.385,86.942,87.442,87.357,88.985,89.3,89.958,88.805,88.937,89.187,89.442,89.377,88.687,88.168,88.206,88.91,89.604,88.593,87.774,87.996,89.094,89.686,89.048,88.866,88.813,89.489,89.492,89.709,89.052,87.557,87.558,87.144,88.382,85.842,84.689,84.461,85.632,84.16,82.275,81.954,81.621,83.199,83.407,84.415,83.679,83.326,84.403,84.883,85.483,83.627,82.573,83.141,85.132,85.961,84.766,85.281,85.172,86.728,87.145,87.676,87.602,86.103,87.252,87.263,87.997,86.792,86.887,86.663,87.728,88.536,87.049,86.928,86.25,86.388,87.44,87.674,88.297,87.011,87.016,87.118,88.721,87.968,86.706,86.273,86.095,86.743,85.009,84.183,84.416,84.634,86.013,85.432,86.441,85.476,85.39,85.551,86.88,86.382,86.925,86.313,86.777,88.178,87.856,85.849,85.602,85.61,86.683,86.961,87.806,86.522,86.373,86.605,87.521,88.042,87.247,87.513,87.318,87.972,88.762,87.279,87.043,86.839,87.534,88.401,87.59,87.059,86.427,86.166,86.312,86.743,85.446,85.479,85.549,85.884,86.496,85.027,84.662,85.331,86.167,86.243,86.297,85.512,85.259,86.62,87.311,88.167,86.94,86.254,87.155,87.209,88.221,88.264,87.231,87.892,88.011,89.115,88.551,88.939,88.283,88.523,88.996,89.824,90.567,90.152,90.695,91.016,90.681,91.029,90.955,90.68,91.11,91.096,91.142,90.665,91.272,91.454,91.38,90.973,91.882,91.964,91.755,91.808,91.923,92.463,92.809,92.642,92.557,92.752,92.782,93.07,93.423,92.975,93.147,93.336,93.423,94.047,94.336,94.197,94.392,94.47,94.514,94.457,94.42,94.127,94.106,94.707,94.734,94.905,94.632,96.935,138.406,139.142,141.177,140.053,139.593,141.47,142.54,143.133,145.037]

1) Do not pessimize the node on Grpc.Core.StatusCode.Cancelled and Grpc.Core.StatusCode.DeadlineExceeded. 2) Dispose of WriterSession using dispose CancellationToken. 3) BidirectionalStream is internal class. 4) Move Metadata class to Ydb.Sdk.Services.Topic. 5) Fixed memory leak CancellationTokenRegistration. 6) Cancel writing tasks after disposing of Writer.

KirillKurdyukov requested a review from alex268 December 24, 2024 15:35

KirillKurdyukov self-assigned this Dec 24, 2024

alex268 approved these changes Dec 24, 2024

View reviewed changes

KirillKurdyukov added 2 commits December 24, 2024 18:39

fix linter

26d3426

Update CHANGELOG.md

3e917d8

KirillKurdyukov added 2 commits December 25, 2024 11:28

Do not pessimize on Grpc.Core.StatusCode.DeadlineExceeded

424fb35

deleted catch on ObjectDisposedException

5cc2eba

KirillKurdyukov merged commit 91869c1 into main Dec 25, 2024
25 checks passed

KirillKurdyukov deleted the feat-update-writer-on-dispose branch December 25, 2024 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: memory leak CancellationTokenRegistration #242

fix: memory leak CancellationTokenRegistration #242

Uh oh!

KirillKurdyukov commented Dec 24, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: memory leak CancellationTokenRegistration #242

fix: memory leak CancellationTokenRegistration #242

Uh oh!

Conversation

KirillKurdyukov commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Operation Success Rate

Operations Per Second

95th Percentile Latency

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KirillKurdyukov commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading