Skip to content

fix flap test: wait for closing execQuery stream from server #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix flap test: wait for closing execQuery stream from server #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34a988c
fix flap test: wait for closing execQuery stream from server
KirillKurdyukov Dec 25, 2024
605b35e
fix linter
KirillKurdyukov Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Ydb.Sdk/tests/Ado/YdbCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,10 @@ public void ExecuteDbDataReader_WhenPreviousIsNotClosed_ThrowException()

Assert.Equal("A command is already in progress: SELECT 1; SELECT 1;",
Assert.Throws<YdbOperationInProgressException>(() => dbCommand.ExecuteReader()).Message);
Assert.True(ydbDataReader.NextResult());
Assert.True(ydbDataReader.NextResult());
Assert.False(ydbDataReader.NextResult());

ydbDataReader.Close();
Assert.True(ydbDataReader.IsClosed);
}
Expand Down Expand Up @@ -331,6 +335,7 @@ public void GetChars_WhenSelectText_MoveCharsToBuffer()
Assert.Equal(checkBuffer, bufferChars);

Assert.Equal('a', ydbDataReader.GetChar(0));
Assert.False(ydbDataReader.Read());
}

[Fact]
Expand Down Expand Up @@ -377,6 +382,7 @@ public void GetBytes_WhenSelectBytes_MoveBytesToBuffer()
checkBuffer[6] = (byte)'b';
checkBuffer[7] = (byte)'a';
Assert.Equal(checkBuffer, bufferChars);
Assert.False(ydbDataReader.Read());
}

[Fact]
Expand Down
5 changes: 5 additions & 0 deletions src/Ydb.Sdk/tests/Ado/YdbTransactionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ public void CommitAndRollback_WhenStreamIsOpened_ThrowException()
Assert.Equal("A command is already in progress: SELECT 1; SELECT 2; SELECT 3",
Assert.Throws<YdbOperationInProgressException>(() => ydbTransaction.Rollback()).Message);

Assert.True(dbDataReader.NextResult());
Assert.True(dbDataReader.NextResult());
Assert.True(dbDataReader.NextResult());
Assert.False(dbDataReader.NextResult());

dbDataReader.Close(); // Close stream
ydbTransaction.Commit();
Assert.Equal("This YdbTransaction has completed; it is no longer usable",
Expand Down
Loading