Skip to content

feat: invoke ReadAsync() on CloseAsync #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2025
Merged

feat: invoke ReadAsync() on CloseAsync #275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdb80a3
feat: invoke ReadAsync() on CloseAsync
KirillKurdyukov Feb 27, 2025
319fc93
fix test ExecuteReader_throws_when_transaction_required
KirillKurdyukov Feb 27, 2025
c8e04bb
Update CHANGELOG.md
KirillKurdyukov Feb 27, 2025
9788b58
Update CHANGELOG.md
KirillKurdyukov Feb 27, 2025
9fe34a9
fix linter
KirillKurdyukov Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Ydb.Sdk/src/Ado/YdbDataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ public override async Task CloseAsync()
}

ReaderMetadata = CloseMetadata.Instance;
var isConsumed = ReaderState == State.IsConsumed;
var isConsumed = ReaderState == State.IsConsumed || !await ReadAsync() && ReaderState == State.IsConsumed;
ReaderState = State.Close;

if (isConsumed)
Expand Down Expand Up @@ -595,7 +595,7 @@ private YdbValue GetFieldYdbValue(int ordinal)
: ydbValue;
}

private async Task<State> NextExecPart()
private async ValueTask<State> NextExecPart()
{
try
{
Expand Down
20 changes: 20 additions & 0 deletions src/Ydb.Sdk/tests/Ado/YdbTransactionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,26 @@ public void Rollback_WhenUpsertThenRollback_ReturnPrevRow()
Assert.Equal(new DateTime(2008, 11, 21), ydbCommand.ExecuteScalar());
}

[Fact]
public void Commit_WhenUpdateWithYdbDataReader_ReturnUpdatedRow()
{
using var connection = CreateOpenConnection();
var ydbTransaction = connection.BeginTransaction();
var ydbCommand = new YdbCommand(connection)
{
CommandText = $@"UPDATE {Tables.Episodes} SET title=""test Episode 2""
WHERE series_id = 2 AND season_id = 5 AND episode_id = 1;"
};
var executeReaderAsync = ydbCommand.ExecuteReader();
executeReaderAsync.Close();
ydbTransaction.Commit();
Assert.Equal("test Episode 2", new YdbCommand(connection)
{
CommandText = $@"SELECT title FROM {Tables.Episodes}
WHERE series_id = 2 AND season_id = 5 AND episode_id = 1;"
}.ExecuteScalar());
}

[Fact]
public void Commit_WhenMakeTwoUpsertOperation_ReturnUpdatedTables()
{
Expand Down
Loading