Skip to content

Update YdbDatabaseModelFactory.cs #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

Update YdbDatabaseModelFactory.cs #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71cf498
Update YdbDatabaseModelFactory.cs
KirillKurdyukov Apr 5, 2025
fab2970
fix linter
KirillKurdyukov Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 67 additions & 55 deletions src/EfCore.Ydb/src/Scaffolding/Internal/YdbDatabaseModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,85 +21,97 @@ public override DatabaseModel Create(string connectionString, DatabaseModelFacto
public override DatabaseModel Create(DbConnection connection, DatabaseModelFactoryOptions options)
{
var ydbConnection = (YdbConnection)connection;
if (connection.State != ConnectionState.Open)
{
connection.Open();
}

var tableNames = new List<string>();
tableNames.AddRange(options.Tables);
var connectionStartedOpen = ydbConnection.State == ConnectionState.Open;

if (tableNames.Count == 0)
if (!connectionStartedOpen)
{
tableNames.AddRange(
from ydbObject in YdbSchema.SchemaObjects(ydbConnection).GetAwaiter().GetResult()
where ydbObject.Type is SchemeType.Table or SchemeType.ColumnTable or SchemeType.ExternalTable &&
!ydbObject.IsSystem
select ydbObject.Name
);
ydbConnection.Open();
}

var databaseModel = new DatabaseModel
try
{
DatabaseName = connection.Database
};
var tableNames = new List<string>();
tableNames.AddRange(options.Tables);

foreach (var ydbTable in tableNames.Select(tableName =>
YdbSchema.DescribeTable(ydbConnection, tableName).GetAwaiter().GetResult()))
{
var databaseTable = new DatabaseTable
if (tableNames.Count == 0)
{
Name = ydbTable.Name,
Database = databaseModel
};
tableNames.AddRange(
from ydbObject in YdbSchema.SchemaObjects(ydbConnection).GetAwaiter().GetResult()
where ydbObject.Type is SchemeType.Table or SchemeType.ColumnTable or SchemeType.ExternalTable &&
!ydbObject.IsSystem
select ydbObject.Name
);
}

var columnNameToDatabaseColumn = new Dictionary<string, DatabaseColumn>();
var databaseModel = new DatabaseModel
{
DatabaseName = connection.Database
};

foreach (var column in ydbTable.Columns)
foreach (var ydbTable in tableNames.Select(tableName =>
YdbSchema.DescribeTable(ydbConnection, tableName).GetAwaiter().GetResult()))
{
var databaseColumn = new DatabaseColumn
var databaseTable = new DatabaseTable
{
Name = column.Name,
Table = databaseTable,
StoreType = column.StorageType,
IsNullable = column.IsNullable
Name = ydbTable.Name,
Database = databaseModel
};

databaseTable.Columns.Add(databaseColumn);
columnNameToDatabaseColumn[column.Name] = databaseColumn;
}
var columnNameToDatabaseColumn = new Dictionary<string, DatabaseColumn>();

foreach (var index in ydbTable.Indexes)
{
var databaseIndex = new DatabaseIndex
foreach (var column in ydbTable.Columns)
{
Name = index.Name,
Table = databaseTable,
IsUnique = index.Type == YdbTableIndex.IndexType.GlobalUniqueIndex
var databaseColumn = new DatabaseColumn
{
Name = column.Name,
Table = databaseTable,
StoreType = column.StorageType,
IsNullable = column.IsNullable
};

databaseTable.Columns.Add(databaseColumn);
columnNameToDatabaseColumn[column.Name] = databaseColumn;
}

foreach (var index in ydbTable.Indexes)
{
var databaseIndex = new DatabaseIndex
{
Name = index.Name,
Table = databaseTable,
IsUnique = index.Type == YdbTableIndex.IndexType.GlobalUniqueIndex
};

foreach (var columnName in index.IndexColumns)
{
databaseIndex.Columns.Add(columnNameToDatabaseColumn[columnName]);
databaseIndex.IsDescending.Add(false);
}

databaseTable.Indexes.Add(databaseIndex);
}

databaseTable.PrimaryKey = new DatabasePrimaryKey
{
Name = null // YDB does not have a primary key named
};

foreach (var columnName in index.IndexColumns)
foreach (var columnName in ydbTable.PrimaryKey)
{
databaseIndex.Columns.Add(columnNameToDatabaseColumn[columnName]);
databaseIndex.IsDescending.Add(false);
databaseTable.PrimaryKey.Columns.Add(columnNameToDatabaseColumn[columnName]);
}

databaseTable.Indexes.Add(databaseIndex);
databaseModel.Tables.Add(databaseTable);
}

databaseTable.PrimaryKey = new DatabasePrimaryKey
{
Name = null // YDB does not have a primary key named
};

foreach (var columnName in ydbTable.PrimaryKey)
return databaseModel;
}
finally
{
if (!connectionStartedOpen)
{
databaseTable.PrimaryKey.Columns.Add(columnNameToDatabaseColumn[columnName]);
ydbConnection.Close();
}

databaseModel.Tables.Add(databaseTable);
}

return databaseModel;
}
}
Loading