Skip to content

Add some fixes for migration #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Add some fixes for migration #305

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cf998c
Add some fixes for migration
MIVerTFT Apr 11, 2025
73ee5b6
Merge branch 'main' into work/somefix
MIVerTFT Apr 11, 2025
6eaea1a
Removed "Generate EnsureSchemaOperation" bypass
MIVerTFT Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.Ydb/src/Migrations/Internal/YdbHistoryRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ private IReadOnlyList<MigrationCommand> SelectHistoryTableCommand() =>
new SqlOperation
{
Sql = $"SELECT * FROM {SqlGenerationHelper.DelimitIdentifier(TableName, TableSchema)}" +
$" WHERE MigrationId = '{LockKey}';"
$" WHERE '{MigrationIdColumnName}' = '{LockKey}';"
}
});

Expand Down
8 changes: 8 additions & 0 deletions src/EFCore.Ydb/src/Migrations/YdbMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,12 @@ protected override void Generate(
// Ignore bc YDB doesn't have foreign keys
}

protected override void Generate(EnsureSchemaOperation operation, IModel? model,
MigrationCommandListBuilder builder)
{
// Ignore bc YDB doesn't support schema
}

protected override void Generate(
AddPrimaryKeyOperation operation,
IModel? model,
Expand Down Expand Up @@ -400,4 +406,6 @@ private void EndStatementSuppressTransaction(MigrationCommandListBuilder builder

private string DelimitIdentifier(string name, string? schema = null)
=> Dependencies.SqlGenerationHelper.DelimitIdentifier(name, schema);


}
Loading