Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Ydb.Sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
- `Connection.State` is set to `Broken` when the session is deactivated.

## v0.16.2

- Fixed bug in method GetSchema(): collection columns return Unspecified when decimal type about column.
Expand Down
2 changes: 1 addition & 1 deletion src/Ydb.Sdk/src/Ado/YdbCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ protected override async Task<DbDataReader> ExecuteDbDataReaderAsync(CommandBeha
await YdbConnection.Session.ExecuteQuery(
preparedSql.ToString(), ydbParameters, execSettings, transaction?.TransactionControl
),
YdbConnection.Session.OnStatus, transaction
YdbConnection.OnStatus, transaction
);

YdbConnection.LastReader = ydbDataReader;
Expand Down
10 changes: 10 additions & 0 deletions src/Ydb.Sdk/src/Ado/YdbConnection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,16 @@ public override string ConnectionString

private ConnectionState ConnectionState { get; set; } = ConnectionState.Closed; // Invoke AsyncOpen()

internal void OnStatus(Status status)
{
_session.OnStatus(status);

if (!_session.IsActive)
{
ConnectionState = ConnectionState.Broken;
}
}

internal YdbDataReader? LastReader { get; set; }
internal string LastCommand { get; set; } = string.Empty;
internal bool IsBusy => LastReader is { IsOpen: true };
Expand Down
4 changes: 2 additions & 2 deletions src/Ydb.Sdk/src/Ado/YdbSchema.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ internal static async Task<YdbTable> DescribeTable(

if (status.IsNotSuccess)
{
ydbConnection.Session.OnStatus(status);
ydbConnection.OnStatus(status);

throw new YdbException(status);
}
Expand All @@ -76,7 +76,7 @@ internal static async Task<YdbTable> DescribeTable(
}
catch (Driver.TransportException e)
{
ydbConnection.Session.OnStatus(e.Status);
ydbConnection.OnStatus(e.Status);

throw new YdbException("Transport error on DescribeTable", e);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Ydb.Sdk/src/Ado/YdbTransaction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ private async Task FinishTransaction(Func<string, Task<Status>> finishMethod)
{
Failed = true;

DbConnection.Session.OnStatus(status);
DbConnection.OnStatus(status);

throw new YdbException(status);
}
Expand All @@ -108,7 +108,7 @@ private async Task FinishTransaction(Func<string, Task<Status>> finishMethod)
{
Failed = true;

DbConnection.Session.OnStatus(e.Status);
DbConnection.OnStatus(e.Status);

throw new YdbException(e.Status);
}
Expand Down
Loading