Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/slo-topic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
cd slo/src/TopicService
dotnet run create "Host=localhost;Port=2135;Database=/Root/testdb"
- name: Run SLO Tests
continue-on-error: true
run: |
cd slo/src/TopicService
dotnet run run "Host=localhost;Port=2135;Database=/Root/testdb" \
Expand Down
8 changes: 6 additions & 2 deletions src/Ydb.Sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
- Fixed bug: Unhandled exception.
System.Net.Http.HttpIOException ([#452](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/451)).
- dev: LogLevel `Warning` -> `Debug` on AttachStream has been cancelled.

## v0.18.0

- Disable Discovery mode: skip discovery step and client balancing and use connection to start endpoint ([#420](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/420)).
- Disable Discovery mode: skip discovery step and client balancing and use connection to start
endpoint ([#420](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/420)).

## v0.17.0

- Shutdown channels which are removed from the EndpointPool after discovery calls.
- Fixed bug: Received message exceeds the maximum configured message size ([#421](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/421)).
- Fixed bug: Received message exceeds the maximum configured message
size ([#421](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/421)).
- Added `MaxSendMessageSize` \ `MaxReceiveMessageSize` grpc message size settings.
- Added `EnableMultipleHttp2Connections` setting to grpc channel.
- `Connection.State` is set to `Broken` when the session is deactivated.
Expand Down
12 changes: 6 additions & 6 deletions src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,9 @@ await stream.AuthToken(),
_deserializer
);
}
catch (Driver.TransportException e)
catch (Exception e)
{
_logger.LogError(e, "Transport error on executing ReaderSession");
_logger.LogError(e, "Error on executing ReaderSession");

_ = Task.Run(Initialize, _disposeCts.Token);
}
Expand Down Expand Up @@ -338,9 +338,9 @@ private async Task RunProcessingStreamResponse()

Logger.LogInformation("ReaderSession[{SessionId}]: ResponseStream is closed", SessionId);
}
catch (Driver.TransportException e)
catch (Exception e)
{
Logger.LogError(e, "ReaderSession[{SessionId}] have transport error on processing server messages",
Logger.LogError(e, "ReaderSession[{SessionId}] have error on processing server messages",
SessionId);
}
finally
Expand All @@ -360,9 +360,9 @@ private async Task RunProcessingStreamRequest()
await SendMessage(messageFromClient);
}
}
catch (Driver.TransportException e)
catch (Exception e)
{
Logger.LogError(e, "ReaderSession[{SessionId}] have transport error on Write", SessionId);
Logger.LogError(e, "ReaderSession[{SessionId}] have error on Write", SessionId);

ReconnectSession();

Expand Down
18 changes: 9 additions & 9 deletions src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,16 @@ await stream.AuthToken(),
_sendInFlightMessagesSemaphoreSlim.Release();
}
}
catch (Driver.TransportException e)
{
_logger.LogError(e, "Transport error on creating WriterSession");

_ = Task.Run(Initialize);
}
catch (OperationCanceledException)
{
_logger.LogInformation("Initialize writer is canceled because it has been disposed");
}
catch (Exception e)
{
_logger.LogError(e, "Error on creating WriterSession");

_ = Task.Run(Initialize);
}
}

public async ValueTask DisposeAsync()
Expand Down Expand Up @@ -493,9 +493,9 @@ public async Task Write(ConcurrentQueue<MessageSending> toSendBuffer)
Volatile.Write(ref _seqNum, currentSeqNum);
await SendMessage(new MessageFromClient { WriteRequest = writeMessage });
}
catch (Driver.TransportException e)
catch (Exception e)
{
Logger.LogError(e, "WriterSession[{SessionId}] have transport error on Write, last SeqNo={SeqNo}",
Logger.LogError(e, "WriterSession[{SessionId}] have error on Write, last SeqNo={SeqNo}",
SessionId, Volatile.Read(ref _seqNum));

ReconnectSession();
Expand Down Expand Up @@ -564,7 +564,7 @@ Completing task on exception...

Logger.LogInformation("WriterSession[{SessionId}]: ResponseStream is closed", SessionId);
}
catch (Driver.TransportException e)
catch (Exception e)
{
Logger.LogError(e, "WriterSession[{SessionId}] have error on processing writeAck", SessionId);
}
Expand Down
Loading