Skip to content

Commit dfdfa28

Browse files
committed
Revert "fix: rm precision"
This reverts commit 570f883.
1 parent 570f883 commit dfdfa28

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

src/components/MemoryViewer/MemoryViewer.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ const b = cn('memory-viewer');
1616
type FormatProgressViewerValues = (
1717
value?: number,
1818
capacity?: number,
19+
precision?: number,
1920
) => (string | number | undefined)[];
2021

2122
export interface MemoryProgressViewerProps {
@@ -29,6 +30,8 @@ export interface MemoryProgressViewerProps {
2930
dangerThreshold?: number;
3031
}
3132

33+
const MEMORY_PRECISION = 1;
34+
3235
export function MemoryViewer({
3336
stats,
3437
value,
@@ -51,7 +54,7 @@ export function MemoryViewer({
5154
capacityText = '';
5255
divider = '';
5356
} else if (formatValues) {
54-
[valueText, capacityText] = formatValues(Number(value), Number(capacity));
57+
[valueText, capacityText] = formatValues(Number(value), Number(capacity), MEMORY_PRECISION);
5558
}
5659

5760
const renderContent = () => {
@@ -105,11 +108,13 @@ export function MemoryViewer({
105108
<ProgressViewer
106109
value={segmentSize}
107110
capacity={segmentCapacity}
108-
formatValues={formatValues}
111+
formatValues={(val, size) =>
112+
formatValues(val, size, MEMORY_PRECISION)
113+
}
109114
colorizeProgress
110115
/>
111116
) : (
112-
formatValues(segmentSize, undefined)[0]
117+
formatValues(segmentSize, undefined, MEMORY_PRECISION)[0]
113118
)}
114119
</DefinitionList.Item>
115120
),

src/utils/dataFormatters/common.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export function formatValues<T>(
2222
size?: T,
2323
delimiter?: string,
2424
withValueLabel = false,
25+
precision?: number,
2526
) {
2627
let calculatedSize = sizeGetter(Number(value), 0);
2728
let valueWithSizeLabel = true;
@@ -37,7 +38,7 @@ export function formatValues<T>(
3738
value,
3839
withSizeLabel: valueWithSizeLabel,
3940
size: size || calculatedSize,
40-
precision: valuePrecision,
41+
precision: precision ?? valuePrecision,
4142
delimiter,
4243
});
4344
const formattedTotal = formatter({

src/utils/dataFormatters/dataFormatters.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export function formatStorageValues(
6161
size?: BytesSizes,
6262
delimiter?: string,
6363
withValueLabel?: boolean,
64+
precision?: number,
6465
) {
6566
return formatValues<BytesSizes>(
6667
formatBytesCustom,
@@ -70,6 +71,7 @@ export function formatStorageValues(
7071
size,
7172
delimiter,
7273
withValueLabel,
74+
precision,
7375
);
7476
}
7577

@@ -91,12 +93,12 @@ export function formatNumericValues(
9193
);
9294
}
9395

94-
export const formatStorageValuesToGb = (value?: number, total?: number) => {
95-
return formatStorageValues(value, total, 'gb');
96+
export const formatStorageValuesToGb = (value?: number, total?: number, precision?: number) => {
97+
return formatStorageValues(value, total, 'gb', undefined, undefined, precision);
9698
};
9799

98-
export const formatStorageValuesToTb = (value?: number, total?: number) => {
99-
return formatStorageValues(value, total, 'tb');
100+
export const formatStorageValuesToTb = (value?: number, total?: number, precision?: number) => {
101+
return formatStorageValues(value, total, 'tb', undefined, undefined, precision);
100102
};
101103

102104
export const formatNumber = (number?: unknown) => {

0 commit comments

Comments
 (0)