-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add rows limit to query settings #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
60b550e
5469b74
a970b28
df16b2d
e55c633
b87e848
f572b1a
adf896f
410a10f
56f9e3f
df1c0bb
07abc0f
cdadfbf
c3fe9af
dcb0f95
67b9d0d
2c30b28
470d285
f64c011
514265d
e0d310d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ | |
| flex: 6; | ||
| } | ||
|
|
||
| &__limit-rows, | ||
| &__timeout { | ||
| width: 33.3%; | ||
| margin-right: var(--g-spacing-2); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -179,6 +179,27 @@ function QuerySettingsForm({initialValues, onSubmit, onClose}: QuerySettingsForm | |
| /> | ||
| </div> | ||
| </Flex> | ||
| <Flex direction="row" alignItems="flex-start" className={b('dialog-row')}> | ||
| <label htmlFor="limitRows" className={b('field-title')}> | ||
| {QUERY_SETTINGS_FIELD_SETTINGS.limitRows.title} | ||
| </label> | ||
| <div className={b('control-wrapper')}> | ||
| <Controller | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add validation in |
||
| name="limitRows" | ||
| control={control} | ||
| render={({field}) => ( | ||
| <React.Fragment> | ||
|
||
| <TextInput | ||
| type="number" | ||
| {...field} | ||
| className={b('limit-rows')} | ||
| placeholder="10000" | ||
| /> | ||
| </React.Fragment> | ||
| )} | ||
| /> | ||
| </div> | ||
| </Flex> | ||
| </Dialog.Body> | ||
| <Dialog.Footer | ||
| textButtonApply={i18n('button-done')} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,6 +233,7 @@ export const executeQueryApi = api.injectEndpoints({ | |
| querySettings.tracingLevel && enableTracingLevel | ||
| ? TracingLevelNumber[querySettings.tracingLevel] | ||
| : undefined, | ||
| limit_rows: querySettings.limitRows || undefined, | ||
|
||
| transaction_mode: | ||
| querySettings.transactionMode === 'implicit' | ||
| ? undefined | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.