Skip to content

ci: add merge group to ci triggers #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2024
Merged

ci: add merge group to ci triggers #1355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aabffb
ci: add merge group to ci triggers
artemmufazalov Sep 24, 2024
eee6760
ci: skip some checks in merge queue
artemmufazalov Sep 24, 2024
dc85799
ci: do not check pr title for merge group
artemmufazalov Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: Node.js CI
on:
pull_request:
branches: ['**']
merge_group:
Copy link
Member Author

@artemmufazalov artemmufazalov Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#merge_group

types: [checks_requested]

jobs:
verify_files:
Expand Down Expand Up @@ -38,6 +40,7 @@ jobs:
e2e_tests:
name: Playwright Tests
runs-on: ubuntu-latest
if: ${{github.event.action != 'checks_requested'}}
permissions:
contents: read

Expand Down Expand Up @@ -121,6 +124,7 @@ jobs:
bundle_size:
name: Check Bundle Size
runs-on: ubuntu-latest
if: ${{github.event.action != 'checks_requested'}}
outputs:
current_size: ${{ steps.current_size.outputs.size }}
main_size: ${{ steps.main_size.outputs.size }}
Expand Down Expand Up @@ -183,7 +187,7 @@ jobs:
deploy_and_update:
name: Deploy and Update PR
needs: [e2e_tests, bundle_size]
if: always() && github.event.pull_request.head.repo.full_name == github.repository
if: ${{always() && github.event.pull_request.head.repo.full_name == github.repository && github.event.action != 'checks_requested'}}
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,14 @@ on:
- synchronize
- reopened
- edited
merge_group:
types: [checks_requested]

jobs:
verify_title:
name: Verify Title
runs-on: ubuntu-latest
if: ${{github.event.action != 'checks_requested'}}
Copy link
Member Author

@artemmufazalov artemmufazalov Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, if job is cancelled due to if condition, its status will be success

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
Loading