Skip to content

feat: paginated tables - enable setting by default #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024
Merged

feat: paginated tables - enable setting by default #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce1915e
feat: paginated tables - enable setting by default
astandrik Oct 14, 2024
04e49ed
fix: fix tests
astandrik Oct 14, 2024
fa7bfec
Merge branch 'main' into astandrik.paginated-tables-enable-setting-by…
astandrik Oct 14, 2024
3806e2d
fix: test
astandrik Oct 14, 2024
f253a7e
Merge branch 'main' into astandrik.paginated-tables-enable-setting-by…
astandrik Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const DEFAULT_USER_SETTINGS = {
[LAST_USED_QUERY_ACTION_KEY]: QUERY_ACTIONS.execute,
[ASIDE_HEADER_COMPACT_KEY]: true,
[PARTITIONS_HIDDEN_COLUMNS_KEY]: [],
[USE_PAGINATED_TABLES_KEY]: false,
[USE_PAGINATED_TABLES_KEY]: true,
[USE_CLUSTER_BALANCER_AS_BACKEND_KEY]: true,
[ENABLE_AUTOCOMPLETE]: true,
[AUTOCOMPLETE_ON_ENTER]: true,
Expand Down
3 changes: 1 addition & 2 deletions tests/suites/nodes/NodesPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import type {Locator, Page} from '@playwright/test';

import {PageModel} from '../../models/PageModel';
import {nodesPage} from '../../utils/constants';
import {selectContentTable} from '../../utils/selectContentTable';

export class NodesPage extends PageModel {
readonly table: Locator;

constructor(page: Page) {
super(page, nodesPage);

this.table = selectContentTable(this.selector);
this.table = this.selector.locator('.ydb-paginated-table__table');
}
}
10 changes: 1 addition & 9 deletions tests/suites/storage/StoragePage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,24 @@ import type {Locator, Page} from '@playwright/test';

import {PageModel} from '../../models/PageModel';
import {storagePage} from '../../utils/constants';
import {selectContentTable} from '../../utils/selectContentTable';

type EntityType = 'Groups' | 'Nodes';
type VisibleEntityType = 'Degraded' | 'Out of space' | 'All';

const storageTypeFilterQa = 'storage-type-filter';
const storageVisibleEntitiesFilterQa = 'storage-visible-entities-filter';

export class StoragePage extends PageModel {
readonly table: Locator;
protected readonly entityTypeSelector: Locator;
protected readonly visibleEntityTypeSelector: Locator;

constructor(page: Page) {
super(page, storagePage);

this.table = selectContentTable(this.selector);
this.table = this.selector.locator('.ydb-paginated-table__table');

this.entityTypeSelector = this.selector.getByTestId(storageTypeFilterQa);
this.visibleEntityTypeSelector = this.selector.getByTestId(storageVisibleEntitiesFilterQa);
}

async selectEntityType(type: EntityType) {
await this.entityTypeSelector.getByLabel(type).click();
}
async selectVisibleEntityType(type: VisibleEntityType) {
await this.visibleEntityTypeSelector.getByLabel(type).click();
}
}
2 changes: 0 additions & 2 deletions tests/suites/storage/storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ test.describe('Test Storage page', async () => {
const storagePage = new StoragePage(page);
await storagePage.goto();

await storagePage.selectVisibleEntityType('All');
await storagePage.selectEntityType('Groups');

await expect(storagePage.table).toBeVisible();
Expand All @@ -25,7 +24,6 @@ test.describe('Test Storage page', async () => {
const storagePage = new StoragePage(page);
await storagePage.goto();

await storagePage.selectVisibleEntityType('All');
await storagePage.selectEntityType('Nodes');

await expect(storagePage.table).toBeVisible();
Expand Down
Loading