feat(Storage,Nodes): request only needed fields from backend #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
changed the title
artemmufazalov
requested review from
Raubzeug and
astandrik
and removed request for
astandrik
Raubzeug
previously approved these changes
Oct 21, 2024
astandrik
requested changes
Oct 21, 2024
Collaborator
astandrik
left a comment
astandrik
left a comment
There was a problem hiding this comment.
discussed to try to get rid of dataFieldsRequired in props
artemmufazalov
force-pushed
the
1249-request-data-base-on-columns
branch
from
d017661 to
ef8bafe
Compare
astandrik
reviewed
Oct 21, 2024
| const [isTimeoutActive, setIsTimeoutActive] = React.useState(true); | ||
| const [autoRefreshInterval] = useAutoRefreshInterval(); | ||
|
|
||
| const columnsIds = columns.map((column) => column.name).sort(); |
Collaborator
There was a problem hiding this comment.
Why do we need to sort them?
astandrik
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249
Stand: https://nda.ya.ru/t/44KfyLRl792MHn
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 79.03 MB | Main: 79.02 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information