Skip to content

fix: cluster layout #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: cluster layout #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cf8432
fix: cluster layout
Raubzeug Oct 21, 2024
23a243d
fix: review
Raubzeug Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/TableWithControlsLayout/TableWithControlsLayout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
@import '../../styles/mixins.scss';

.ydb-table-with-controls-layout {
--data-table-sticky-top-offset: 62px;

display: inline-block;

box-sizing: border-box;
Expand Down Expand Up @@ -31,11 +33,11 @@
}

.ydb-paginated-table__head {
top: 62px;
top: var(--data-table-sticky-top-offset, 62px);
}

.data-table__sticky_moving {
// Place table head right after controls
top: 62px !important;
top: var(--data-table-sticky-top-offset, 62px) !important;
Copy link
Member

@artemmufazalov artemmufazalov Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use it for paginated table as well (ydb-paginated-table__head)

}
}
6 changes: 5 additions & 1 deletion src/containers/Cluster/Cluster.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import '../../styles/mixins.scss';

.cluster {
.ydb-cluster {
position: relative;

overflow: auto;
Expand Down Expand Up @@ -74,4 +74,8 @@

background-color: var(--g-color-base-background);
}

.ydb-table-with-controls-layout {
--data-table-sticky-top-offset: 102px;
}
}
2 changes: 1 addition & 1 deletion src/containers/Cluster/Cluster.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import {clusterTabs, clusterTabsIds, getClusterPath, isClusterTab} from './utils

import './Cluster.scss';

const b = cn('cluster');
const b = cn('ydb-cluster');

interface ClusterProps {
additionalTenantsProps?: AdditionalTenantsProps;
Expand Down
Loading