Skip to content

fix: correct width for columns with ProgressViewer #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: correct width for columns with ProgressViewer #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/nodesColumns/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ export function getMemoryColumn<
/>
),
align: DataTable.LEFT,
width: 140,
resizeMinWidth: 140,
width: 170,
resizeMinWidth: 170,
};
}
export function getSharedCacheUsageColumn<
Expand All @@ -126,8 +126,8 @@ export function getSharedCacheUsageColumn<
/>
),
align: DataTable.LEFT,
width: 140,
resizeMinWidth: 140,
width: 170,
resizeMinWidth: 170,
};
}
export function getCpuColumn<T extends {PoolStats?: TPoolStats[]}>(): Column<T> {
Expand Down Expand Up @@ -162,8 +162,8 @@ export function getLoadAverageColumn<T extends {LoadAveragePercents?: number[]}>
/>
),
align: DataTable.LEFT,
width: 140,
resizeMinWidth: 140,
width: 170,
resizeMinWidth: 170,
};
}
// The same as loadAverage, but more compact
Expand Down
6 changes: 3 additions & 3 deletions src/containers/Clusters/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
{
name: COLUMNS_NAMES.NODES,
header: COLUMNS_TITLES[COLUMNS_NAMES.NODES],
resizeMinWidth: 140,
resizeMinWidth: 170,
defaultOrder: DataTable.DESCENDING,
sortAccessor: ({cluster = {}}) => {
const {NodesTotal = 0} = cluster;
Expand All @@ -166,7 +166,7 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
{
name: COLUMNS_NAMES.LOAD,
header: COLUMNS_TITLES[COLUMNS_NAMES.LOAD],
resizeMinWidth: 140,
resizeMinWidth: 170,
defaultOrder: DataTable.DESCENDING,
sortAccessor: ({cluster}) => {
return cluster?.NumberOfCpus;
Expand All @@ -184,7 +184,7 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
{
name: COLUMNS_NAMES.STORAGE,
header: COLUMNS_TITLES[COLUMNS_NAMES.STORAGE],
resizeMinWidth: 140,
resizeMinWidth: 170,
defaultOrder: DataTable.DESCENDING,
sortAccessor: ({cluster}) => {
return Number(cluster?.StorageTotal);
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Node/NodeStructure/Pdisk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function getColumns({
{
name: VDiskTableColumnsIds.Size,
header: vDiskTableColumnsNames[VDiskTableColumnsIds.Size],
width: 100,
width: 170,
render: ({row}) => {
return (
<ProgressViewer
Expand Down
4 changes: 2 additions & 2 deletions src/containers/Versions/NodesTable/NodesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ const columns: Column<PreparedNodeSystemState>[] = [
header: 'Load average',
sortAccessor: ({LoadAveragePercents = []}) => LoadAveragePercents[0],
defaultOrder: DataTable.DESCENDING,
width: 140,
resizeMinWidth: 140,
width: 170,
resizeMinWidth: 170,
render: ({row}) =>
row.LoadAveragePercents && row.LoadAveragePercents.length > 0 ? (
<ProgressViewer
Expand Down
Loading