fix(EntityStatus): remove additionalControls, fix ClipboardButton layout #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Oct 23, 2024
|
|
||
| if (data?.Rack) { | ||
| info.push({label: 'Rack', value: data.Rack}); | ||
| info.push({name: 'Rack', children: data.Rack, key: i18n('field_rack')}); |
Member
There was a problem hiding this comment.
Looks like key and name were mixed up
Comment on lines
47
to
51
| <DefinitionList responsive> | ||
| <DefinitionList.Item name={i18n('field_monitoring-link')}> | ||
| {monitoringLink} | ||
| </DefinitionList.Item> | ||
| </DefinitionList> |
Member
There was a problem hiding this comment.
Let's use the same form as in Cluster overview: "Links: Monitoring". Icon in popover looks weird
Member
|
Please, use more informative PR name, it's not only layout fix |
Raubzeug
force-pushed
the
entity-status-fixes
branch
from
cf41039 to
cdc4d02
Compare
Raubzeug
changed the title
artemmufazalov
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1439
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔺
Current: 79.10 MB | Main: 79.03 MB
Diff: +0.07 MB (0.08%)
ℹ️ CI Information