Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 20, 2024

Closes #1656

Stand

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
176 176 0 0 0

Bundle Size: βœ…

Current: 66.11 MB | Main: 66.11 MB
Diff: +0.00 MB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json: Language not supported
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json: Language not supported
  • src/containers/UserSettings/i18n/en.json: Language not supported

@astandrik astandrik requested a review from Copilot November 20, 2024 10:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json: Language not supported
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json: Language not supported
  • src/containers/UserSettings/i18n/en.json: Language not supported
Comments skipped due to low confidence (1)

src/utils/hooks/useQueryExecutionSettings.ts:13

  • [nitpick] The variable name useShowPlanToSvg is ambiguous. It should be renamed to isPlanToSvgEnabled for better clarity.
const [useShowPlanToSvg] = useSetting<boolean>(USE_SHOW_PLAN_SVG_KEY);

@astandrik astandrik requested a review from Copilot November 20, 2024 10:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json: Language not supported
  • src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json: Language not supported
  • src/containers/UserSettings/i18n/en.json: Language not supported
Comments skipped due to low confidence (1)

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsSelect.tsx:38

  • The new disabled prop should be covered by tests to ensure it works as expected.
disabled={props.disabled}

@astandrik astandrik added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit e973bae Nov 20, 2024
7 checks passed
@astandrik astandrik deleted the astandrik.plan2svg-comprehensive-1656 branch November 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: plan2svg comprehensive

3 participants