Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 25, 2024

Closes #1679

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
202 202 0 0 0
Test Changes Summary ✨4

✨ New Tests (4)

  1. Shows error for limit rows > 100000 (tenant/queryEditor/querySettings.test.ts)
  2. Shows error for negative limit rows (tenant/queryEditor/querySettings.test.ts)
  3. Persists valid limit rows value (tenant/queryEditor/querySettings.test.ts)
  4. Allows empty limit rows value (tenant/queryEditor/querySettings.test.ts)

Bundle Size: βœ…

Current: 66.09 MB | Main: 66.09 MB
Diff: +0.00 KB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@astandrik astandrik requested a review from Copilot November 25, 2024 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

tests/suites/tenant/queryEditor/models/SettingsDialog.ts:101

  • [nitpick] The method name getLimitRowsErrorMessage should be renamed to getLimitRowErrorMessage for consistency.
async getLimitRowsErrorMessage() {

@astandrik astandrik added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit db8ec37 Nov 25, 2024
8 checks passed
@astandrik astandrik deleted the astandrik.make-limit-rows-1679 branch November 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: make limit rows less or equal to 100_000

4 participants