Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 25, 2024

Closes #1682

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
208 208 0 0 0
Test Changes Summary ✨7

✨ New Tests (7)

  1. Memory viewer is visible and has correct status (memoryViewer/memoryViewer.test.ts)
  2. Memory viewer shows correct base metrics (memoryViewer/memoryViewer.test.ts)
  3. Memory viewer popup shows on hover with all metrics (memoryViewer/memoryViewer.test.ts)
  4. Shows error for limit rows > 100000 (tenant/queryEditor/querySettings.test.ts)
  5. Shows error for negative limit rows (tenant/queryEditor/querySettings.test.ts)
  6. Persists valid limit rows value (tenant/queryEditor/querySettings.test.ts)
  7. Allows empty limit rows value (tenant/queryEditor/querySettings.test.ts)

Bundle Size: βœ…

Current: 66.09 MB | Main: 66.09 MB
Diff: +0.62 KB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@astandrik astandrik added this pull request to the merge queue Nov 26, 2024
@astandrik astandrik removed this pull request from the merge queue due to a manual request Nov 26, 2024
@astandrik astandrik added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 05094d7 Nov 26, 2024
7 checks passed
@astandrik astandrik deleted the astandrik.use-AllocatedMemory-1682 branch November 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: use AllocatedMemory+AllocatedCachesMemory instead of AnonRss if not present

3 participants