Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Nov 26, 2024

Closes #616

With dynamicRenderType: 'variable' and dynamicItemSizeGetter table renders all its cells, it causes performance issues on big tables.

Rendering of a query result table with 100 000 rows.

With dynamicRenderType: 'variable' and dynamicItemSizeGetter:
100_000 before

With 'uniform' rendering:
100_000 after

Stand: https://nda.ya.ru/t/VwIwqa8k79xSUi

Select 100 000 rows from kv_test table to check

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
208 208 0 0 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 66.09 MB | Main: 66.09 MB
Diff: 0.19 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit d93e866 Nov 27, 2024
7 checks passed
@artemmufazalov artemmufazalov deleted the 616-optimise-query-result branch November 27, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimise query results

3 participants