Skip to content

fix(Versions): tune default color #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(Versions): tune default color #1719

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
819b9d8
fix(Versions): tune default color
Raubzeug Nov 28, 2024
1fa75e9
fix: review
Raubzeug Nov 28, 2024
553cbc9
fix: review
Raubzeug Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/utils/versions/getVersionsColors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const hashCode = (s: string) => {
// TODO: colors used in charts as well, need to move to constants
// 11 distinct colors from https://mokole.com/palette.html
export const COLORS = [
'#008000', // green
Copy link
Collaborator

@ValeraS ValeraS Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before all the changes, there were 11 colors (see comment in the code above). Let's not change the number of colors.

'#4169e1', // royalblue
'#ffd700', // gold
'#ff8c00', // darkorange
Copy link
Collaborator

@ValeraS ValeraS Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

Copy link
Contributor Author

@Raubzeug Raubzeug Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentionally :(

Expand All @@ -20,11 +21,11 @@ export const COLORS = [
'#ff1493', // deeppink
'#00bfff', // deepskyblue
'#da70d6', // orchid
'#3cb371', // mediumseagreen
'#8b4513', //saddlebrown
'#b22222', // firebrick
];

export const DEFAULT_COLOR = '#008000'; // green
export const DEFAULT_COLOR = '#3cb371'; // mediumseagreen

export const getVersionsMap = (versions: string[], initialMap: VersionsMap = new Map()) => {
versions.forEach((version) => {
Expand Down
Loading