feat: change uptime format #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1067-change-uptime-format
branch
from
3b2169c to
765f264
Compare
artemmufazalov
force-pushed
the
1067-change-uptime-format
branch
from
765f264 to
061f4a0
Compare
Raubzeug
requested changes
Dec 12, 2024
| * It works well only with positive values, | ||
| * if you want to get negative formatted uptime, use some wrapper like getDowntimeFromDateFormatted | ||
| */ | ||
| export function formatUptimeInSeconds(seconds: number) { |
There was a problem hiding this comment.
lets handle somehow negative values. As for me this function should work properly with all values. And we should use it for negative and positive uptime.
Raubzeug
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067
Stand (there is hardcoded uptime in Nodes table for demonstration): https://nda.ya.ru/t/jnRsXjJ47AKdRa
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.88 MB | Main: 65.88 MB
Diff: +0.63 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information