Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Dec 23, 2024

Closes #1755
Closes #919

Stand

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
222 222 0 0 0

😟 No changes in tests. πŸ˜•

Bundle Size: πŸ”Ί

Current: 66.16 MB | Main: 65.89 MB
Diff: +0.27 MB (0.41%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@astandrik astandrik force-pushed the astandrik.view-query-text-on-info-919-2 branch from d05b88c to 14ca9f9 Compare December 23, 2024 12:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • package.json: Language not supported
  • src/components/YqlHighlighter/YqlHighlighter.scss: Language not supported
  • playwright.config.ts: Evaluated as low risk

return (
<CellWithPopover contentClassName={b('popover-content')} content={value}>
{value}
<CellWithPopover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a popover here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed popover
redeployed stand

@astandrik astandrik requested a review from Raubzeug December 23, 2024 14:10
@astandrik astandrik added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit d590f05 Dec 23, 2024
7 checks passed
@astandrik astandrik deleted the astandrik.view-query-text-on-info-919-2 branch December 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use read-only monaco editor to display queries in history and saved views Display VIEW query text on Info tab inside read-only monaco

3 participants