-
Notifications
You must be signed in to change notification settings - Fork 17
feat: download dump with all info #1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
27d4d7b
feat: download dump with all info
astandrik e1acac6
fix: use toaster
astandrik 94dc5df
fix: nanofix
astandrik 9a3f22a
fix: add error to diagnostics
astandrik 4d7f4a2
Merge branch 'main' into astandrik.984
astandrik 9bb5f0b
fix: remove from local storage
astandrik 017fb56
fix: review fixes
astandrik 1198790
fix: review issues
astandrik e34a0f9
fix: tests
astandrik 64f3775
fix: tests
astandrik 8d3c67e
Merge branch 'main' into astandrik.984
astandrik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 0 additions & 112 deletions
112
src/containers/Tenant/Query/QueryResult/components/PlanToSvgButton/PlanToSvgButton.tsx
This file was deleted.
Oops, something went wrong.
17 changes: 17 additions & 0 deletions
17
src/containers/Tenant/Query/QueryResult/components/QueryInfoDropdown/QueryInfoDropdown.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .query-info-dropdown { | ||
| &__menu-item { | ||
| align-items: start; | ||
| } | ||
|
|
||
| &__menu-item-content { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| padding: var(--g-spacing-1) 0; | ||
| } | ||
|
|
||
| &__icon { | ||
| margin-top: var(--g-spacing-2); | ||
| margin-right: var(--g-spacing-2); | ||
| } | ||
| } |
55 changes: 55 additions & 0 deletions
55
src/containers/Tenant/Query/QueryResult/components/QueryInfoDropdown/QueryInfoDropdown.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import {Ellipsis} from '@gravity-ui/icons'; | ||
| import type {ButtonProps} from '@gravity-ui/uikit'; | ||
| import {Button, DropdownMenu, Tooltip} from '@gravity-ui/uikit'; | ||
|
|
||
| import i18n from '../../i18n'; | ||
|
|
||
| import type {QueryResultsInfo} from './useQueryInfoMenuItems'; | ||
| import {useQueryInfoMenuItems} from './useQueryInfoMenuItems'; | ||
|
|
||
| import './QueryInfoDropdown.scss'; | ||
|
|
||
| interface QueryInfoDropdownProps { | ||
| queryResultsInfo: QueryResultsInfo; | ||
| database: string; | ||
| hasPlanToSvg: boolean; | ||
| } | ||
|
|
||
| export function QueryInfoDropdown({ | ||
| queryResultsInfo, | ||
| database, | ||
| hasPlanToSvg, | ||
| }: QueryInfoDropdownProps) { | ||
| const {error, isLoading, items} = useQueryInfoMenuItems({ | ||
| queryResultsInfo, | ||
| database, | ||
| hasPlanToSvg, | ||
| }); | ||
|
|
||
| const renderSwitcher = (props: ButtonProps) => { | ||
| return ( | ||
| <Tooltip content={error ? i18n('text_error-plan-svg', {error}) : i18n('text_plan-svg')}> | ||
| <Button view="flat-secondary" loading={isLoading} disabled={isLoading} {...props}> | ||
| <Button.Icon> | ||
| <Ellipsis /> | ||
| </Button.Icon> | ||
| </Button> | ||
| </Tooltip> | ||
| ); | ||
| }; | ||
|
|
||
| if (!items.length) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <DropdownMenu | ||
| popupProps={{ | ||
| placement: ['bottom-end', 'left'], | ||
| }} | ||
| renderSwitcher={renderSwitcher} | ||
| items={items} | ||
| size="xl" | ||
| /> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets' move
queryTexton top, so it would be easier to identify what about diagnostics file is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed