Skip to content

fix(SchemaTree): expand nodes if ChildrenExist is undefined #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(SchemaTree): expand nodes if ChildrenExist is undefined #1872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/containers/Tenant/ObjectSummary/SchemaTree/SchemaTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {selectUserInput} from '../../../../store/reducers/query/query';
import {schemaApi} from '../../../../store/reducers/schema/schema';
import {tableSchemaDataApi} from '../../../../store/reducers/tableSchemaData';
import type {EPathType, TEvDescribeSchemeResult} from '../../../../types/api/schema';
import {valueIsDefined} from '../../../../utils';
import {
useQueryExecutionSettings,
useTypedDispatch,
Expand Down Expand Up @@ -78,12 +79,16 @@ export function SchemaTree(props: SchemaTreeProps) {
const childItems = Children.map((childData) => {
const {Name = '', PathType, PathSubType, ChildrenExist} = childData;

const isChildless =
isChildlessPathType(PathType, PathSubType) ||
(valueIsDefined(ChildrenExist) && !ChildrenExist);

return {
name: Name,
type: mapPathTypeToNavigationTreeType(PathType, PathSubType),
// FIXME: should only be explicitly set to true for tables with indexes
// at the moment of writing there is no property to determine this, fix later
expandable: !isChildlessPathType(PathType, PathSubType) && ChildrenExist,
expandable: !isChildless,
};
});

Expand Down
Loading