fix(Tenant): fix tabs reset on schema object change #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1880-fix-tabs-reset
branch
2 times, most recently
from
88fd814 to
0101a66
Compare
artemmufazalov
commented
Jan 29, 2025
Comment on lines
+110
to
+115
| const currentPathType = | ||
| currentItem?.PathDescription?.Self?.PathType ?? | ||
| preloadedData?.PathDescription?.Self?.PathType; | ||
| const currentPathSubType = | ||
| currentItem?.PathDescription?.Self?.PathSubType ?? | ||
| preloadedData?.PathDescription?.Self?.PathSubType; |
There was a problem hiding this comment.
Use type and sub type from object parent's Children field.
On initial load there will be loader and tabs will be rendered with full data. Further preloaded data from schema tree will be used to correctly render tabs
artemmufazalov
force-pushed
the
1880-fix-tabs-reset
branch
from
0101a66 to
03976d9
Compare
Raubzeug
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1880
Stand: https://nda.ya.ru/t/V1P0upfw7BXe2E
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.19 MB | Main: 80.19 MB
Diff: +3.04 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information