feat(ErrorBoundary): rework error page #1983
Conversation
artemmufazalov
force-pushed
the
1583-improve-error-boundary
branch
from
e69684b to
57d9b37
Compare
| } | ||
| } | ||
|
|
||
| return ''; |
There was a problem hiding this comment.
Return empty string instead of some placeholder to reduce output size in case of unknown error
artemmufazalov
force-pushed
the
1583-improve-error-boundary
branch
from
57d9b37 to
ea5247e
Compare
| userAgent: navigator.userAgent, | ||
| error: { | ||
| message: prepareErrorMessage(error), | ||
| stack: prepareErrorStack(error.stack, {trim: true, maxLength: 10}), |
There was a problem hiding this comment.
Trim and limit trace to ensure it will fit in QR
artemmufazalov
requested review from
Raubzeug and
astandrik
and removed request for
Raubzeug
| } | ||
| } | ||
|
|
||
| function prepareErrorMessage(error: unknown) { |
There was a problem hiding this comment.
Maybe use this logic?
There was a problem hiding this comment.
Moved this code to utils and used in ErrorBoundary
| document.body.removeChild(link); | ||
| } | ||
|
|
||
| export const createAndDownloadJsonFile = (data: unknown, fileName: string) => { |
There was a problem hiding this comment.
did you want to add downloading of error's diagnostics?
There was a problem hiding this comment.
I added it in first version, but then removed since we decided to replace it with QR. These functions now are used only in query diagnostics, but I left them in utils since they fit there
There was a problem hiding this comment.
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/components/ErrorBoundary/ErrorBoundary.tsx:57
- The variable 'b' is used to set the className in multiple components (e.g. in ErrorBoundaryFallback and ErrorStack) but there is no definition or import for 'b'. Make sure to import or define 'b' appropriately.
<Flex direction="column" gap={4} className={b(null)}>
src/components/ErrorBoundary/__tests__/prepareErrorStack.test.ts
Outdated
Show resolved
Hide resolved
Closes #1583
Where I checked my QRs:
Stand: https://nda.ya.ru/t/MrUUOOfl7CHYFg
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 80.72 MB | Main: 80.62 MB
Diff: +0.10 MB (0.12%)
ℹ️ CI Information