Skip to content

fix(TopShards): display table for column entities #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix(TopShards): display table for column entities #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/containers/Tenant/Diagnostics/Diagnostics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function Diagnostics(props: DiagnosticsProps) {
return <TopQueries tenantName={tenantName} />;
}
case TENANT_DIAGNOSTICS_TABS_IDS.topShards: {
return <TopShards tenantName={tenantName} path={path} type={type} />;
return <TopShards tenantName={tenantName} path={path} />;
}
case TENANT_DIAGNOSTICS_TABS_IDS.nodes: {
return (
Expand Down
9 changes: 1 addition & 8 deletions src/containers/Tenant/Diagnostics/TopShards/TopShards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,11 @@ import {
import {EShardsWorkloadMode} from '../../../../store/reducers/shardsWorkload/types';
import type {ShardsWorkloadFilters} from '../../../../store/reducers/shardsWorkload/types';
import type {CellValue, KeyValueRow} from '../../../../types/api/query';
import type {EPathType} from '../../../../types/api/schema';
import {cn} from '../../../../utils/cn';
import {DEFAULT_TABLE_SETTINGS} from '../../../../utils/constants';
import {formatDateTime} from '../../../../utils/dataFormatters/dataFormatters';
import {useAutoRefreshInterval, useTypedDispatch, useTypedSelector} from '../../../../utils/hooks';
import {parseQueryErrorToString} from '../../../../utils/query';
import {isColumnEntityType} from '../../utils/schema';

import {Filters} from './Filters';
import {getShardsWorkloadColumns} from './columns/columns';
Expand Down Expand Up @@ -60,10 +58,9 @@ function fillDateRangeFor(value: ShardsWorkloadFilters) {
interface TopShardsProps {
tenantName: string;
path: string;
type?: EPathType;
}

export const TopShards = ({tenantName, path, type}: TopShardsProps) => {
export const TopShards = ({tenantName, path}: TopShardsProps) => {
const dispatch = useTypedDispatch();
const location = useLocation();

Expand Down Expand Up @@ -163,10 +160,6 @@ export const TopShards = ({tenantName, path, type}: TopShardsProps) => {
return null;
}

if (!data || isColumnEntityType(type)) {
Copy link
Member Author

@artemmufazalov artemmufazalov Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason column top shards tab exist for column tables, but there was alway "no-data" message. It seems now it works just fine and this table could be shown for column tables

return i18n('no-data');
}

return (
<ResizeableDataTable
columnsWidthLSKey={TOP_SHARDS_COLUMNS_WIDTH_LS_KEY}
Expand Down
Loading