Skip to content

feat(TopShards): colorize usage #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

feat(TopShards): colorize usage #2003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions src/containers/Tenant/Diagnostics/TopShards/columns/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ import {getDefaultNodePath} from '../../../../Node/NodePages';

import {TOP_SHARDS_COLUMNS_IDS, TOP_SHARDS_COLUMNS_TITLES} from './constants';

function prepareCPUWorkloadValue(value: string | number) {
return `${roundToPrecision(Number(value) * 100, 2)}%`;
}

const getPathColumn = (schemaPath: string, location: Location): Column<KeyValueRow> => ({
name: TOP_SHARDS_COLUMNS_IDS.Path,
header: TOP_SHARDS_COLUMNS_TITLES.Path,
Expand All @@ -32,15 +28,6 @@ const getPathColumn = (schemaPath: string, location: Location): Column<KeyValueR
width: 300,
});

const cpuCoresColumn: Column<KeyValueRow> = {
name: TOP_SHARDS_COLUMNS_IDS.CPUCores,
header: TOP_SHARDS_COLUMNS_TITLES.CPUCores,
render: ({row}) => {
return prepareCPUWorkloadValue(row.CPUCores || 0);
},
align: DataTable.RIGHT,
};

const dataSizeColumn: Column<KeyValueRow> = {
name: TOP_SHARDS_COLUMNS_IDS.DataSize,
header: TOP_SHARDS_COLUMNS_TITLES.DataSize,
Expand Down Expand Up @@ -75,21 +62,17 @@ const nodeIdColumn: Column<KeyValueRow> = {
align: DataTable.RIGHT,
};

const topShardsCpuCoresColumn: Column<KeyValueRow> = {
const cpuCoresColumn: Column<KeyValueRow> = {
name: TOP_SHARDS_COLUMNS_IDS.CPUCores,
header: TOP_SHARDS_COLUMNS_TITLES.CPUCores,
render: ({row}) => {
return (
<UsageLabel
value={roundToPrecision(Number(row.CPUCores) * 100, 2)}
theme={getUsageSeverity(Number(row.CPUCores) * 100)}
/>
);
const usage = Number(row.CPUCores) * 100 || 0;

return <UsageLabel value={roundToPrecision(usage, 2)} theme={getUsageSeverity(usage)} />;
},
align: DataTable.RIGHT,
sortable: false,
width: 140,
resizeMinWidth: 140,
width: 110,
resizeMinWidth: 110,
};

const inFlightTxCountColumn: Column<KeyValueRow> = {
Expand All @@ -111,5 +94,5 @@ export const getShardsWorkloadColumns = (schemaPath: string, location: Location)
};

export const getTopShardsColumns = (schemaPath: string, location: Location) => {
return [tabletIdColumn, getPathColumn(schemaPath, location), topShardsCpuCoresColumn];
return [tabletIdColumn, getPathColumn(schemaPath, location), cpuCoresColumn];
};
Loading