Skip to content

fix: add required field SubDomainKey to getNodes #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: add required field SubDomainKey to getNodes #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/containers/Cluster/Cluster.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function Cluster({
const clusterTitle = metaClusterTitle ?? viewerClusterTitle;

const {
data: {clusterData: cluster = {}, groupsStats} = {},
data: {clusterData: cluster, groupsStats} = {},
isLoading: infoLoading,
error,
} = clusterApi.useGetClusterInfoQuery(clusterName ?? undefined);
Expand Down Expand Up @@ -121,7 +121,7 @@ export function Cluster({
</div>
{isClusterDashboardAvailable && (
<ClusterDashboard
cluster={cluster}
cluster={cluster ?? {}}
groupStats={groupsStats}
loading={infoLoading}
error={clusterError || cluster?.error}
Expand Down Expand Up @@ -193,7 +193,7 @@ export function Cluster({
getLocationObjectFromHref(getClusterPath(clusterTabsIds.versions)).pathname
}
>
<Versions cluster={cluster} />
{cluster && <Versions cluster={cluster} />}
</Route>
<Route
render={() => (
Expand Down
4 changes: 2 additions & 2 deletions src/containers/Versions/Versions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import './Versions.scss';
const b = cn('ydb-versions');

interface VersionsProps {
cluster?: TClusterInfo;
cluster: TClusterInfo;
}

export const Versions = ({cluster}: VersionsProps) => {
Expand All @@ -29,7 +29,7 @@ export const Versions = ({cluster}: VersionsProps) => {

const versionsValues = useGetVersionValues(cluster, versionToColor);
const {currentData, isLoading: isNodesLoading} = nodesApi.useGetNodesQuery(
{tablets: false, fieldsRequired: ['SystemState']},
{tablets: false, fieldsRequired: ['SystemState', 'SubDomainKey']},
{pollingInterval: autoRefreshInterval},
);

Expand Down
2 changes: 1 addition & 1 deletion src/containers/Versions/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const useGetVersionValues = (cluster?: TClusterInfo, versionToColor?: Ver
? skipToken
: {
tablets: false,
fieldsRequired: ['SystemState'],
fieldsRequired: ['SystemState', 'SubDomainKey'],
group: 'Version',
},
);
Expand Down
Loading