Skip to content

fix: stream test in safari #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix: stream test in safari #2059

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a353ee
fix: stream test in safari
astandrik Mar 28, 2025
a43b53b
fix: stream test in safari
Mar 28, 2025
4ce59f5
fix: word
Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/suites/tenant/queryEditor/queryEditor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,14 @@ test.describe('Test Query Editor', async () => {

test('Streaming query shows some results and banner when stop button is clicked', async ({
page,
browserName,
}) => {
// For some reason Safari handles large numbers list bad in Safari
// Will be investigated here https://github.com/ydb-platform/ydb-embedded-ui/issues/1989
test.skip(browserName === 'webkit', 'This test is skipped in Safari');
// Safari in playwright has problem with drawing an array
// of million values for frequently appearing rows.
// But still need them for heavy responses to simulate
// long running queries. Setting their display to none resolves the issue.
await page.addStyleTag({
content: '.ydb-query-result-sets-viewer__result tr td:nth-child(3n) { display: none; }',
});
const queryEditor = new QueryEditor(page);
await toggleExperiment(page, 'on', 'Query Streaming');

Expand Down
Loading