Skip to content

feat: add support for RealNumberOfCpus for load average #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025
Merged

feat: add support for RealNumberOfCpus for load average #2082

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54a0eb9
feat: add support for RealNumberOfCpus for load average
astandrik Apr 1, 2025
4fe369d
fix: nanofix
astandrik Apr 1, 2025
34fe48e
fix: nanofix
astandrik Apr 1, 2025
815952f
fix: use only for calculation
astandrik Apr 1, 2025
53b0b4a
fix: review fixes
astandrik Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/types/api/nodes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export interface TSystemStateInfo {
/** double */
LoadAverage?: number[];
NumberOfCpus?: number;
RealNumberOfCpus?: number;
SystemState?: EFlag;
MessageBusState?: EFlag;
GRpcState?: EFlag;
Expand Down
7 changes: 4 additions & 3 deletions src/utils/nodes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,15 @@ export const prepareNodesMap = (nodesList?: TNodeInfo[]) => {
};

export function calculateLoadAveragePercents(node: TSystemStateInfo = {}) {
const {LoadAverage, NumberOfCpus} = node;
const {LoadAverage, NumberOfCpus, RealNumberOfCpus} = node;
const cpuCount = RealNumberOfCpus ?? NumberOfCpus;

if (!valueIsDefined(LoadAverage) || !valueIsDefined(NumberOfCpus)) {
if (!valueIsDefined(LoadAverage) || !valueIsDefined(cpuCount) || cpuCount === 0) {
Copy link
Contributor

@Raubzeug Raubzeug Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!valueIsDefined(LoadAverage) || !cpuCount ?

return undefined;
}

return LoadAverage.map((value) => {
return (value * 100) / NumberOfCpus;
return (value * 100) / cpuCount;
});
}

Expand Down
Loading