Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 3, 2025

Closes #2073

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
298 298 0 0 0
Test Changes Summary ✨6

✨ New Tests (6)

  1. TopShards tab defaults to Immediate mode (tenant/diagnostics/diagnostics.test.ts)
  2. TopShards immediate tab shows all expected column headers (tenant/diagnostics/diagnostics.test.ts)
  3. TopShards history tab shows all expected column headers (tenant/diagnostics/diagnostics.test.ts)
  4. TopShards tab first row has values for all columns in Immediate mode (tenant/diagnostics/diagnostics.test.ts)
  5. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/diagnostics.test.ts)
  6. TopShards tab can switch back to Immediate mode from Historical mode (tenant/diagnostics/diagnostics.test.ts)

Bundle Size: βœ…

Current: 83.25 MB | Main: 83.25 MB
Diff: 0.00 KB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@astandrik astandrik requested a review from Copilot April 3, 2025 11:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces e2e tests for the TopShards table in diagnostics and updates the memory viewer widget to improve verification and numeric formatting.

  • Added a mock data generator for TopShards table in History mode.
  • Extended diagnostics tests to cover Immediate and Historical modes for TopShards.
  • Updated memory viewer tests to handle decimal values in GB formatting.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/suites/tenant/diagnostics/mocks.ts Adds a mock data generator for simulating TopShards table rows
tests/suites/tenant/diagnostics/diagnostics.test.ts Introduces new tests covering mode selection and header validations
tests/suites/tenant/diagnostics/Diagnostics.ts Adds methods for header verification and TopShards mode selection
tests/suites/memoryViewer/memoryViewer.test.ts Updates regex in memory tests to support decimals in GB values

@astandrik astandrik added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 10e173c Apr 3, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2073 branch April 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: e2e-test top shards table

3 participants