Skip to content

fix: use blue color only for not replicated vdisks #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix: use blue color only for not replicated vdisks #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a07562
fix: use blue color only for not replicated vdisks
artemmufazalov Apr 4, 2025
7c7c3b2
add tests
artemmufazalov Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/utils/disks/__test__/calculateVDiskSeverity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,20 @@ describe('VDisk state', () => {
expect(severity).not.toEqual(DISK_COLOR_STATE_TO_NUMERIC_SEVERITY.Blue);
});

test('Should not display VDisk as replicating if DiskSpace or FrontQueues are blue', () => {
const severity1 = calculateVDiskSeverity({
VDiskState: EVDiskState.OK,
FrontQueues: EFlag.Blue,
});
const severity2 = calculateVDiskSeverity({
VDiskState: EVDiskState.OK,
DiskSpace: EFlag.Blue,
});

expect(severity1).not.toEqual(DISK_COLOR_STATE_TO_NUMERIC_SEVERITY.Blue);
expect(severity2).not.toEqual(DISK_COLOR_STATE_TO_NUMERIC_SEVERITY.Blue);
});

test('Should display replicating VDisks in a not-OK state with a regular color', () => {
const severity1 = calculateVDiskSeverity({
VDiskState: EVDiskState.Initial, // severity 3, yellow
Expand Down
7 changes: 6 additions & 1 deletion src/utils/disks/calculateVDiskSeverity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {EFlag} from '../../types/api/enums';
import {EFlag} from '../../types/api/enums';
import type {EVDiskState} from '../../types/api/vdisk';

import {
Expand Down Expand Up @@ -52,5 +52,10 @@ function getColorSeverity(color?: EFlag) {
return NOT_AVAILABLE_SEVERITY;
}

// Blue is reserved for not replicated VDisks
Copy link
Member Author

@artemmufazalov artemmufazalov Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getColorSeverity is used to convert DiskSpace and FrontQueues flags to severity

if (color === EFlag.Blue) {
return DISK_COLOR_STATE_TO_NUMERIC_SEVERITY.Green;
}

return DISK_COLOR_STATE_TO_NUMERIC_SEVERITY[color] ?? NOT_AVAILABLE_SEVERITY;
}
Loading