Skip to content

fix: try no unsaved for templates #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

fix: try no unsaved for templates #2117

merged 3 commits into from
Apr 8, 2025

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 7, 2025 •
edited by github-actions bot
Loading

Closes #2037

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
312 311 0 1 0
Test Changes Summary ✨3 🗑️1

✨ New Tests (3)

  1. Unsaved changes modal appears when switching between templates if query was edited (tenant/queryEditor/queryTemplates.test.ts)
  2. Switching between templates does not trigger unsaved changes modal (tenant/queryEditor/queryTemplates.test.ts)
  3. Selecting a template and then opening history query does not trigger unsaved changes modal (tenant/queryEditor/queryTemplates.test.ts)

🗑️ Deleted Tests (1)

  1. Unsaved changes modal appears when switching between templates (tenant/queryEditor/queryTemplates.test.ts)

Bundle Size: ✅

Current: 83.28 MB | Main: 83.28 MB
Diff: +0.09 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit e7d4a50 Apr 8, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2037-2 branch April 8, 2025 09:26
@ydb-platform-bot ydb-platform-bot mentioned this pull request Apr 7, 2025
Merged
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: try no unsaved for templates

3 participants

@astandrik @artemmufazalov