Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Apr 18, 2025

Closes #2115

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.36 MB | Main: 83.36 MB
Diff: +0.07 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the condition for displaying the "Create DB" button in the Tenants component so that it only appears when the table has finished loading.

  • Refactors the condition by extracting a local variable for clarity
  • Adds a check for table loading state before rendering the button
Comments suppressed due to low confidence (1)

src/containers/Tenants/Tenants.tsx:92

  • [nitpick] Consider renaming 'buttonAvailable' to 'isCreateDBButtonVisible' for enhanced clarity in conveying its purpose.
if (buttonAvailable && !loading) {

@artemmufazalov artemmufazalov added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit b82e029 Apr 18, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 2115-fix-create-db-button branch April 18, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create DB button jumps when databases table is loaded

3 participants