Skip to content

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Apr 26, 2025

closes #2195
stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 316 0 2 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.37 MB | Main: 83.37 MB
Diff: 1.22 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug requested a review from astandrik April 26, 2025 18:03
@Raubzeug
Copy link
Contributor Author

@astandrik found out that almost all tables under tabs in Cluster page has same problems with filters. So in this PR I fix all of them.

Comment on lines 3 to 10
@mixin cluster-full-width-area() {
width: unset;
margin-right: -40px;
padding-right: 40px;
padding-left: 20px;

transform: translateX(-20px);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think off a better approach? It seems, there is no such problem on other pages, where paginated tables are used (Diagnostics, Node, PDisk, VDisk), so the problem is somewhere in cluster page layout

Copy link
Member

@artemmufazalov artemmufazalov Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is a problem, but the problem is connected with TableGroups, your PR fixes it only for Storage and there is still a bug for Nodes table. I suggest updating css for TableGroups themselves, instead of adding some hacks for wrappers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've totally reworked this PR. It seems to look much nicer now!
Stand is redeployed.

@Raubzeug Raubzeug force-pushed the cluster-layout-bug branch from 498b37f to 9e1a14c Compare April 29, 2025 13:57
@Raubzeug Raubzeug requested a review from artemmufazalov April 29, 2025 14:08
@Raubzeug Raubzeug force-pushed the cluster-layout-bug branch from 9e1a14c to 3daa6b1 Compare April 29, 2025 14:10
@Raubzeug Raubzeug force-pushed the cluster-layout-bug branch from 3daa6b1 to 8d1349e Compare April 29, 2025 14:13
@Raubzeug Raubzeug added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit cc454d6 Apr 30, 2025
7 checks passed
@Raubzeug Raubzeug deleted the cluster-layout-bug branch April 30, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cluster page layout bug

3 participants