-
Notifications
You must be signed in to change notification settings - Fork 17
chore: refrigerator as component #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the SQL queries used in the top queries reducer by including new columns (Rank and SessionId), enhances sorting flexibility in top queries via an optional initialSort parameter, and introduces a new Drawer component with context support in the Diagnostics view.
- Updated SQL queries in executeTopQueries to include additional columns.
- Integrated a new QueryHash column into running queries configuration and improved sorting in the relevant hook.
- Introduced a new Drawer component along with minor enhancements in Search and SyntaxHighlighter components.
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/reducers/executeTopQueries/executeTopQueries.ts | Added new columns (Rank and SessionId) to both main and session queries. |
| src/containers/Tenant/Diagnostics/TopQueries/utils.ts | Refactored sorting hook to accept an optional initialSort parameter. |
| src/containers/Tenant/Diagnostics/TopQueries/columns/constants.ts | Introduced 'QueryHash' into the default running queries columns. |
| src/containers/Tenant/Diagnostics/TopQueries/columns/columns.tsx | Adjusted running queries column order to include queryHashColumn. |
| src/containers/Tenant/Diagnostics/Diagnostics.tsx | Wrapped page content with DrawerContextProvider to support new Drawer features. |
| src/components/SyntaxHighlighter/YDBSyntaxHighlighter.tsx | Updated inline styling to merge additional padding styles based on clipboard button settings. |
| src/components/Search/Search.tsx | Added an inputRef prop to forward external refs to the TextInput component. |
| src/components/Drawer/* | Added new DrawerContext and Drawer components for enhanced side-panel support. |
Files not reviewed (2)
- src/components/Drawer/Drawer.scss: Language not supported
- src/containers/Tenant/Diagnostics/Diagnostics.scss: Language not supported
Comments suppressed due to low confidence (4)
src/store/reducers/executeTopQueries/executeTopQueries.ts:70
- Ensure the new 'Rank' column is supported by downstream logic and is properly defined in associated data interfaces.
Rank
src/store/reducers/executeTopQueries/executeTopQueries.ts:95
- Verify that including 'SessionId' in the query aligns with the expected database schema and that consuming code handles this new column accordingly.
SessionId
src/containers/Tenant/Diagnostics/TopQueries/columns/constants.ts:40
- Confirm that the 'QueryHash' column exists in the data source and is correctly integrated into UI components that rely on it.
'QueryHash'
src/components/Search/Search.tsx:57
- Ensure that the TextInput component supports the 'controlRef' prop so that the forwarded ref functions as intended.
controlRef={inputRef}
|
|
||
| // Margin is not counted in height | ||
| // thats why we need to subtract it. | ||
| height: calc(100% - var(--g-spacing-4)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let move it to variable like --diagnostics-margin-top: var(--g-spacing-4)
Closes #2224
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 83.38 MB | Main: 83.37 MB
Diff: +6.76 KB (0.01%)
ℹ️ CI Information