Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 29, 2025

Closes #2224

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: 🔺

Current: 83.38 MB | Main: 83.37 MB
Diff: +6.76 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik changed the title chore: refrigerator as component chore: refrigerator as component Apr 29, 2025
@astandrik astandrik requested a review from Raubzeug April 29, 2025 11:33
@astandrik astandrik requested a review from Copilot April 29, 2025 13:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SQL queries used in the top queries reducer by including new columns (Rank and SessionId), enhances sorting flexibility in top queries via an optional initialSort parameter, and introduces a new Drawer component with context support in the Diagnostics view.

  • Updated SQL queries in executeTopQueries to include additional columns.
  • Integrated a new QueryHash column into running queries configuration and improved sorting in the relevant hook.
  • Introduced a new Drawer component along with minor enhancements in Search and SyntaxHighlighter components.

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/store/reducers/executeTopQueries/executeTopQueries.ts Added new columns (Rank and SessionId) to both main and session queries.
src/containers/Tenant/Diagnostics/TopQueries/utils.ts Refactored sorting hook to accept an optional initialSort parameter.
src/containers/Tenant/Diagnostics/TopQueries/columns/constants.ts Introduced 'QueryHash' into the default running queries columns.
src/containers/Tenant/Diagnostics/TopQueries/columns/columns.tsx Adjusted running queries column order to include queryHashColumn.
src/containers/Tenant/Diagnostics/Diagnostics.tsx Wrapped page content with DrawerContextProvider to support new Drawer features.
src/components/SyntaxHighlighter/YDBSyntaxHighlighter.tsx Updated inline styling to merge additional padding styles based on clipboard button settings.
src/components/Search/Search.tsx Added an inputRef prop to forward external refs to the TextInput component.
src/components/Drawer/* Added new DrawerContext and Drawer components for enhanced side-panel support.
Files not reviewed (2)
  • src/components/Drawer/Drawer.scss: Language not supported
  • src/containers/Tenant/Diagnostics/Diagnostics.scss: Language not supported
Comments suppressed due to low confidence (4)

src/store/reducers/executeTopQueries/executeTopQueries.ts:70

  • Ensure the new 'Rank' column is supported by downstream logic and is properly defined in associated data interfaces.
Rank

src/store/reducers/executeTopQueries/executeTopQueries.ts:95

  • Verify that including 'SessionId' in the query aligns with the expected database schema and that consuming code handles this new column accordingly.
SessionId

src/containers/Tenant/Diagnostics/TopQueries/columns/constants.ts:40

  • Confirm that the 'QueryHash' column exists in the data source and is correctly integrated into UI components that rely on it.
'QueryHash'

src/components/Search/Search.tsx:57

  • Ensure that the TextInput component supports the 'controlRef' prop so that the forwarded ref functions as intended.
controlRef={inputRef}


// Margin is not counted in height
// thats why we need to subtract it.
height: calc(100% - var(--g-spacing-4));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let move it to variable like --diagnostics-margin-top: var(--g-spacing-4)

@astandrik astandrik enabled auto-merge April 29, 2025 14:13
@astandrik astandrik added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 0ec2f98 Apr 29, 2025
5 checks passed
@astandrik astandrik deleted the astandrik.2224-2 branch April 29, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: refrigerator as component

3 participants