Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented May 6, 2025

now that doesnt look as a library common-purpose solution at all...

better remove internal-specific implementation and just leave getLogsLink as an optional function passing to AppWithClusters getLogsLink as a function if logs source exists

major release as backward compatibility breaks here

#2260 (comment)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.47 MB | Main: 83.47 MB
Diff: 2.17 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the internal-specific implementation of the getLogsLink function to promote a common-purpose solution.

  • Removed the internal getLogsLink function and its associated tests.
  • Updated AppWithClusters to no longer rely on a predefined getLogsLink default.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/utils/logs.ts Removed internal-specific getLogsLink implementation.
src/utils/test/logs.test.ts Removed tests related to the now-deleted getLogsLink.
src/containers/AppWithClusters/AppWithClusters.tsx Removed default import and prop for getLogsLink.

@astandrik astandrik added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 816a712 May 7, 2025
8 checks passed
@astandrik astandrik deleted the astandrik.remove-internal-logs-implementation branch May 7, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants