Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented May 15, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.53 MB | Main: 83.53 MB
Diff: +0.06 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think we can just do this with the same effect

@artemmufazalov
Copy link
Member Author

image

I think we can just do this with the same effect

Empty string is the reason, why we have search= in query. If it is undefined there is no param, if it is empty string - there will be empty param

@artemmufazalov
Copy link
Member Author

IMG_20250515_210301_214.jpg

The problem I solve is search= in query

@astandrik
Copy link
Collaborator

astandrik commented May 15, 2025

I dont have search= in query with initialState: ''

image
Screen.Recording.2025-05-15.at.21.37.14.mov

@astandrik
Copy link
Collaborator

astandrik commented May 15, 2025

@artemmufazalov I understood your task and spent some time searching for an alternative more concise solution =)

I think setting initialState to empty string is this solution

as with initialState: '' the moment the value becomes an empty string the library thinks “we’re back to default” and removes search from location.search.

video in previous comment is what I get setting initialState in main to ''

@artemmufazalov artemmufazalov force-pushed the tenants-remove-empty-search branch from ae8f0f4 to b03f3df Compare May 16, 2025 13:20
@artemmufazalov artemmufazalov requested a review from astandrik May 16, 2025 13:20
@artemmufazalov artemmufazalov enabled auto-merge May 16, 2025 13:20
@artemmufazalov artemmufazalov added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 2664ec7 May 16, 2025
5 checks passed
@artemmufazalov artemmufazalov deleted the tenants-remove-empty-search branch May 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants