feat(Tenants): add onEditDB to uiFactory, add edit button #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
May 20, 2025
src/containers/Tenants/Tenants.tsx
Outdated
| defaultSwitcherProps={{ | ||
| view: 'flat', | ||
| size: 's', | ||
| pin: 'brick-brick', |
There was a problem hiding this comment.
As I see in Figma, default pin should be used.
| isEditDBAvailable?: boolean; | ||
| isDeleteDBAvailable?: boolean; | ||
| }) { | ||
| return { |
There was a problem hiding this comment.
I think, such a column should be sticky.
There was a problem hiding this comment.
Created an issue for this to discuss and do it later: #2310
- I don't want to add any changes to table while Anton is solving performance issues and doing a lot of tables refactoring - it may cause conflicts
- I think it should be discussed it with the designer first
- For our tables it may require some tricky css, because there are no sticky columns in react-data-table by props. So I'd prefer to do it after our planned tasks will be done
Raubzeug
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2096, edit form itself will be added internally
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.57 MB | Main: 83.57 MB
Diff: +3.17 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information