Skip to content

fix(Nodes): request tablets only if required #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artemmufazalov merged 1 commit into from
Jun 19, 2025
Merged

fix(Nodes): request tablets only if required #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/containers/Nodes/getNodes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,9 @@ import {getRequiredDataFields} from '../../utils/tableUtils/getRequiredDataField
export const getNodes: FetchData<
NodesPreparedEntity,
NodesFilters,
Pick<NodesRequestParams, 'type' | 'storage' | 'tablets'>
Pick<NodesRequestParams, 'type' | 'storage'>
> = async (params) => {
const {
type = 'any',
storage = false,
tablets = true,
limit,
offset,
sortParams,
filters,
columnsIds,
} = params;
const {type = 'any', storage = false, limit, offset, sortParams, filters, columnsIds} = params;

const {sortOrder, columnId} = sortParams ?? {};
const {
Expand All @@ -46,7 +37,6 @@ export const getNodes: FetchData<
const response = await window.api.viewer.getNodes({
type,
storage,
tablets,
limit,
offset,
sort,
Expand Down
5 changes: 3 additions & 2 deletions src/services/api/viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class ViewerAPI extends BaseYdbAPI {
getNodes(
{
type = 'any',
tablets = false,
tablets,
database,
tenant,
fieldsRequired,
Expand All @@ -119,7 +119,8 @@ export class ViewerAPI extends BaseYdbAPI {
this.getPath('/viewer/json/nodes?enums=true'),
{
type,
tablets,
// Use tablets for backward compatibility even if fieldsRequired is passed
tablets: tablets ?? fieldsRequired?.includes('Tablets'),
// Do not send empty string
filter: filter || undefined,
// TODO: remove after remove tenant param
Expand Down
Loading